fixes ocsp signer lookup in the cert manager. #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Read for review @cconlon . |
|
Is it correct (and secure) to leave the fallback in place to the issuerHash, if issuerKeyHash lookup fails? Does the RFC mention guidance for this somewhere? |
|
no, I was afraid of breaking something that was already working, but that doesn't seems to be the case. I checked GetCA() and removed the fallback. |
|
ready for review @cconlon |
|
Assigning to @ejohnstown for review since I'll be out of the office for the next week. |
|
could you retest this please jenkins? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks for CA based on issuerKeyHash instead of issuerHash.
I still kept the issuerHash lookup if the issuerKeyHash lookup fails.