Fix Espressif component cmake for environment variable source #7148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gojimmypi
force-pushed
the
PR-fix-Espressif-cmake
branch
from
0402f6c
to
92ab2ea
Compare
dgarske
approved these changes
Jan 19, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in the wolfSSL support forum there's currently a mistake the the Espressif component
CMakelists.txtwhen using an environment variable to point to theWOLFSSL_ROOT.This PR corrects the
FIND_WOLFSSL_DIRECTORYCmake function for non-blank values of$ENV{WOLFSSL_ROOT}to properly useif( FOUND_WOLFSSL ).Edit: This PR was updated with a force push to merge a second commit; Return logic was added when the environment variable setting for
WOLFSSL_ROOTwas found and contained wolfssl source.Fixes zd# n/a
Testing
How did you test?
Manual project building only.
Checklist