Added code to automatically populate supported ECC curve information #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unless already provided by user via wolfSSL_CTX_UseSupportedCurve or wolfSSL_UseSupportedCurve.
|
@JacobBarthelmeh, will you do a preliminary review for me? Then assign over to Todd for final review/merge. |
JacobBarthelmeh
previously requested changes
Jan 19, 2017
| } /* is not server */ | ||
| #endif | ||
| } | ||
| #else |
There was a problem hiding this comment.
I don't think that this should be an else case. QSH extension is 0x17 and elliptic curves extension is 0x0a. Both can be sent with the same Client Hello.
There was a problem hiding this comment.
Glad you caught that! Thanks!
…pulating supported curves.
dgarske
dismissed
JacobBarthelmeh’s stale review
Fixed. Going to assign this over to Todd when Jenkins is done. Thanks
JacobBarthelmeh
approved these changes
Jan 19, 2017
bagder
added a commit
to curl/curl
that referenced
this pull request
Feb 22, 2019
since wolfSSL PR wolfSSL/wolfssl#717 (shipped in wolfSSL 3.10.2 and later) it sends these curves by default already. Pointed-out-by: David Garske
bagder
added a commit
to curl/curl
that referenced
this pull request
Feb 23, 2019
since wolfSSL PR wolfSSL/wolfssl#717 (shipped in wolfSSL 3.10.2 and later) it sends these curves by default already. Pointed-out-by: David Garske Closes #3599
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless already provided by user via wolfSSL_CTX_UseSupportedCurve or wolfSSL_UseSupportedCurve.