Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing stdio.h include on Freescale MQX. Use sprintf as snprintf is not available on MQX. #7580

Merged
merged 1 commit into from
May 29, 2024

Conversation

kareem-wolfssl
Copy link
Contributor

Description

Please describe the scope of the fix or feature addition.

Fixes zd#17975

@kareem-wolfssl kareem-wolfssl self-assigned this May 23, 2024
@bandi13
Copy link
Contributor

bandi13 commented May 23, 2024

retest this please

@josepho0918
Copy link
Contributor

@kareem-wolfssl This modification will cause an "XSNPRINTF not defined error" in the MQX environment. Additionally, MQX actually does support snprintf which is implemented as _io_snprintf.

@kareem-wolfssl
Copy link
Contributor Author

Thanks for the clarification @josepho0918 , I did not find any documentation that MQX supports snprintf so I was not clear. Can you confirm if the updated PR works for you?

@josepho0918
Copy link
Contributor

Thanks for the clarification @josepho0918 , I did not find any documentation that MQX supports snprintf so I was not clear. Can you confirm if the updated PR works for you?

Now it works.😊

@kareem-wolfssl
Copy link
Contributor Author

Thanks, customer has also confirmed the fix is working.

@dgarske dgarske merged commit 3e9f656 into wolfSSL:master May 29, 2024
105 checks passed
jefferyq2 pushed a commit to jefferyq2/wolfssl that referenced this pull request Jun 9, 2024
Fix missing stdio.h include on Freescale MQX.  Use sprintf as snprintf is not available on MQX.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants