Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package go 1.18 #385

Closed
imjasonh opened this issue Jan 6, 2023 · 1 comment · Fixed by #408
Closed

Package go 1.18 #385

imjasonh opened this issue Jan 6, 2023 · 1 comment · Fixed by #408
Assignees

Comments

@imjasonh
Copy link
Contributor

imjasonh commented Jan 6, 2023

Upstream Go supports the last two releases, which right now are 1.18 and 1.19. We only package 1.19 today.

I think we should follow the example set by go-1.20.yaml (an unreleased rc) and package go-1.18.yaml and go-1.19.yaml, with a go package in go.yaml that simply has a runtime dependency on the latest stable go release (currently go-1.19).

When go-1.20 is officially released (expected "Feb 2023"), go.yaml can update to point to go-1.20, go-1.18.yaml can be deleted as it's no longer supported upstream (the go-1.18 package would continue to exist ~forever), and folks who want 1.19 can still get it by depending on the go-1.19 package.

We'd follow this same process with go-1.21 has an rc, and later the full release.

Does this sound right @kaniini ?

@kaniini
Copy link
Collaborator

kaniini commented Jan 9, 2023

Yes all of that seems right to me!

The only difference is that we don't need go.yaml, we can just do the same thing we do in samurai.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants