Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apko: install using git-checkout to get version info #826

Merged
merged 1 commit into from Mar 23, 2023

Conversation

imjasonh
Copy link
Contributor

@imjasonh imjasonh commented Mar 23, 2023

Fixes #825

This changes the build from using go/install to using git-checkout and runs: make ... so that Git version info is available to be injected into the binary using ldflags.

This also adds an explicit build-time dependency on go (previously implicit from using go/install), and removes the explicit build-time dep on git (now implicit from using git-checkout).

This also removes the runtime dependency on apk-tools, which is no longer necessary since v0.7.0.

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates

For security-related PRs

  • The security fix is recorded in annotations and secfixes

For version bump PRs

  • The epoch field is reset to 0
  • Patch source: patch source here

@imjasonh imjasonh requested a review from a team as a code owner March 23, 2023 14:30
@imjasonh imjasonh force-pushed the apko-version branch 5 times, most recently from 90d637f to f74ef90 Compare March 23, 2023 15:51
Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh imjasonh merged commit 5594581 into wolfi-dev:main Mar 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apko build package missing version information
2 participants