Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup #2

Merged
merged 2 commits into from
Mar 26, 2024
Merged

cleanup #2

merged 2 commits into from
Mar 26, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jul 18, 2023

No description provided.

@cpanato cpanato force-pushed the cleanup branch 3 times, most recently from e7e354d to 8f430ee Compare July 18, 2023 13:50
@cpanato cpanato marked this pull request as ready for review July 18, 2023 13:53
@cpanato cpanato requested a review from jdolitsky July 18, 2023 13:53
jdolitsky
jdolitsky reviewed Jul 18, 2023
View reviewed changes
action.yml Show resolved Hide resolved
@cpanato cpanato requested a review from jdolitsky July 18, 2023 15:41
jdolitsky
jdolitsky reviewed Jul 18, 2023
View reviewed changes
Copy link
Member

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, looks like lots of debug lines still in the non-debug run?

@mattmoor
Copy link

Y'all still interested in this?

@cpanato
Copy link
Member Author

cpanato commented Mar 26, 2024

the [🐙] Enabling debug logging. only shows up in the debug job the other seems ok

@cpanato
Copy link
Member Author

cpanato commented Mar 26, 2024

@mattmoor @jdolitsky PTAL

jdolitsky
jdolitsky approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jdolitsky jdolitsky merged commit c7bc05c into main Mar 26, 2024
2 checks passed
@jdolitsky jdolitsky deleted the cleanup branch March 26, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdolitsky jdolitsky jdolitsky approved these changes

@mattmoor mattmoor Awaiting requested review from mattmoor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpanato @mattmoor @jdolitsky