Book detail: title and shadow #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dorian30
suggested changes
Jun 10, 2019
maquetado/scss/styles.scss
Outdated
| position: relative; | ||
| margin-bottom: 40px; | ||
| &::after { | ||
| content:""; |
maquetado/scss/colors.scss
Outdated
| @@ -1 +1,3 @@ | |||
| $gray: #828282; | |||
| $earls-green: #BED23C; | |||
| $shadow-background: rgba(0,0,0,0.5); | |||
There was a problem hiding this comment.
Since this is black with some opacity I would change this name to $black-05
maquetado/scss/styles.scss
Outdated
| padding: 10px; | ||
| padding: 20px; | ||
| background-color: #FFF; | ||
| box-shadow: 4px 4px 10px 0 $shadow-background; |
maquetado/scss/styles.scss
Outdated
| @@ -3,7 +3,10 @@ | |||
| } | |||
|
|
|||
| .book-container { | |||
| padding: 10px; | |||
| padding: 20px; | |||
| background-color: #FFF; | |||
maquetado/scss/styles.scss
Outdated
| padding: 20px; | ||
| background-color: #FFF; | ||
| box-shadow: 4px 4px 10px 0 $shadow-background; | ||
| width: 1000px; |
There was a problem hiding this comment.
Remember to read our CSS style guide. There it says that elements with a width higher than 250px have to use following structure for responsive purposes:
Suggested change
| width: 1000px; | |
| max-width: 1000px; | |
| width: 100%; |
Dorian30
suggested changes
Jun 10, 2019
maquetado/scss/styles.scss
Outdated
| margin-right: 40px; | ||
| width: 261px; |
There was a problem hiding this comment.
Remember the style guide here, this is greater than 250px:
Suggested change
| width: 261px; | |
| width: 100%; | |
| max-width: 261px; |
Dorian30
approved these changes
Jun 10, 2019
Dorian30
suggested changes
Jun 10, 2019
maquetado/scss/styles.scss
Outdated
| @@ -11,9 +11,11 @@ | |||
| } | |||
|
|
|||
| .book-cover { | |||
| height: 368px; | |||
| height: 100%; | |||
| max-width: 380px; | |||
There was a problem hiding this comment.
This is not necessary when it comes to height. You can just leave height: 380px.
Dorian30
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added title border and shadow
Screenshots
Trello Card
https://trello.com/c/qCqZRvZE/33-detalle-de-libro-iii-estructura