Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Book detail: title and shadow #5

Merged
merged 10 commits into from Jun 10, 2019
Merged

Book detail: title and shadow #5

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
53e31d8
added bottom border to title
bhflm Jun 7, 2019
a87c232
add title border and box shadow
bhflm Jun 7, 2019
d521cd0
merge
bhflm Jun 7, 2019
73ba6e4
merge
bhflm Jun 7, 2019
ef8223f
fix merge
bhflm Jun 7, 2019
1402d31
Merge branch 'book-detail-pic' into book-detail-structure
bhflm Jun 10, 2019
6281749
added requested changes
bhflm Jun 10, 2019
9050193
fix height & width
bhflm Jun 10, 2019
2750565
merge
bhflm Jun 10, 2019
33f19f7
Merge branch 'book-detail-pic' into book-detail-structure
bhflm Jun 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions maquetado/scss/styles.scss
View file
Open in desktop
Expand Up @@ -11,9 +11,11 @@
}

.book-cover {
height: 368px;
height: 100%;
max-width: 380px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessary when it comes to height. You can just leave height: 380px.

margin-right: 40px;
width: 261px;
width: 100%;
max-width: 260px;
}

.book-detail-value {
Expand Down