Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falsely recognizes tags in a time value (field 86) #12

Closed
batjko opened this issue Jul 21, 2015 · 4 comments
Closed

Falsely recognizes tags in a time value (field 86) #12

batjko opened this issue Jul 21, 2015 · 4 comments

Comments

@batjko
Copy link

batjko commented Jul 21, 2015

Hi,

I just found that if tag 86 contains a time formatted like hh:mm:ss the :mm: portion will be recognized as a tag and if incidentally that minute portion is not an actual tag, it will freak out:

Here's an excerpt of the message in question. Note the time portion in the first 86 tag:

:61:1507160716CD7500,00FMSC1971033191//IA004587508020
NONEREF
:86:eDeposit in Branch/Store 07/16/15 10:33:22 AM 1800 S NEVADA AVE C
OLORADO SPRINGS CO 5133
:61:1507160716DD8000,00FCHK4201//IA008510335677
NONEREF
:86:CHECK
:62F:C150716USD706403,50
:64:C150716USD706403,50
:65:C150717USD706403,50

Results in:
AssertionError: Unknown tag 33in line: ':33:'

@wolph
Copy link
Owner

wolph commented Jul 21, 2015

That's a nice one, apparently (some of) the regexes don't look for the tag at the beginning of the line... that's a bit silly. Shouldn't be too hard to fix

@batjko
Copy link
Author

batjko commented Jul 21, 2015

Thanks for your quick responses!
This module is super helpful for what I am trying to do! 👍

@wolph wolph closed this as completed in 08f52ab Aug 12, 2015
wolph added a commit that referenced this issue Aug 12, 2015
Fixed #12. Previously matched tags in the middle of the line
@wolph
Copy link
Owner

wolph commented Aug 12, 2015

Took a while to actually fix it. But it's released now :)

@batjko
Copy link
Author

batjko commented Aug 12, 2015

Awesome! I'll update and try it out.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants