Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #53 Sberbank Statement format #54

Merged
merged 4 commits into from
Dec 23, 2017

Conversation

csfulop
Copy link

@csfulop csfulop commented Dec 22, 2017

Statement regex is updated to allow spaces

@coveralls
Copy link

coveralls commented Dec 22, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 39ae442 on csfulop:bugfix/53_sberbank into fb551bc on WoLpH:develop.

@wolph
Copy link
Owner

wolph commented Dec 22, 2017

Thanks for the help! I don't have time to fully review it but the pytest-runner issue is nothing to worry about. That bug has been reported upstream but the developer can't easily fix it: pytest-dev/pytest-runner#36

I'm still pondering whether to simply drop the pytest-runner integration and replace it with a few lines of code: https://pytest.readthedocs.io/en/reorganize-docs/goodpractices.html#manual-integration
Or find a way to ignore the pep8 incompliance in pytest-runner

@csfulop
Copy link
Author

csfulop commented Dec 23, 2017

For me it is strange that for some python versions it pass and for some it fails.
And it complains for .eggs dir, there are some cached dependencies there, I think it should not be checked.
Now in Christmas holiday I have some free time, I can have a look and try to ignore :)

@coveralls
Copy link

coveralls commented Dec 23, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling b483677 on csfulop:bugfix/53_sberbank into fb551bc on WoLpH:develop.

@csfulop
Copy link
Author

csfulop commented Dec 23, 2017

Now there is only problem with python 3.3.
It seems it conflicts with pytest:

pytest requires Python '>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*' but the running Python is 3.3.6

Are you really need 3.3? If not then we can drop it.

@wolph
Copy link
Owner

wolph commented Dec 23, 2017

No, we can drop 3.3 :)
That's the thing with packages like these, the tests work fine for several months and after that they break because something became deprecated ;)

@coveralls
Copy link

coveralls commented Dec 23, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling e756b76 on csfulop:bugfix/53_sberbank into fb551bc on WoLpH:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling edcac62 on csfulop:bugfix/53_sberbank into fb551bc on WoLpH:develop.

1 similar comment
@coveralls
Copy link

coveralls commented Dec 23, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling edcac62 on csfulop:bugfix/53_sberbank into fb551bc on WoLpH:develop.

@csfulop
Copy link
Author

csfulop commented Dec 23, 2017

Ok, now 3.3 is dropped and travis is green again :)

@wolph
Copy link
Owner

wolph commented Dec 23, 2017

Awesome! Thank you so much for the help. I'll push a new release soon

@wolph wolph merged commit a61713a into wolph:develop Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants