Update models.py

[apro]

ignore empty/incomplete tags i.e.
...
:NS:
...

[coveralls]

Coverage remained the same at ?% when pulling ed99506 on apro:patch-2 into 0223c7a on WoLpH:develop.

[wolph]

Most tags are definitely not allowed to be empty/incomplete so if a tag should be allowed empty it should be an exclusion specifically for that tag.

In this case, the NonSwift tag: https://github.com/WoLpH/mt940/blob/develop/mt940/tags.py#L199-L238

[apro]

OK, but i've no idea, how to do it properly :/ In such a case (line with only :NS:) parse raises error: File "/usr/lib/python2.7/site-packages/mt940/models.py", line 417, in parse tag_dict = tag.parse(self, tag_data) File "/usr/lib/python2.7/site-packages/mt940/tags.py", line 73, in parse match = re.match(pattern, part_value, self.RE_FLAGS) File "/usr/lib64/python2.7/re.py", line 137, in match return _compile(pattern, flags).match(string) File "/usr/lib64/python2.7/re.py", line 242, in _compile raise error, v # invalid expression sre_constants.error: unbalanced parenthesis for regex pattern = r''' (?P<non_swift> (\d{2}.{0,}) (\n\d{2}.{0,})* ) $''' pattern is splitted line by line thus such a error Next problem - I think there is a logical error in tags.py line 83 - i my undenrstanding Raise should be indented further in else clause. Otherwise I've see no point to matching splitted regex in lines 71-82. czw., 23 maj 2019 o 18:04 Rick van Hattem <notifications@github.com> napisał(a):

…

Most tags are definitely not allowed to be empty/incomplete so if a tag should be allowed empty it should be an exclusion specifically for that tag. In this case, the NonSwift tag: https://github.com/WoLpH/mt940/blob/develop/mt940/tags.py#L199-L238 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#74>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB272XXU3ZN6X3KENBBN3DPW257XANCNFSM4HPCJC4A> .

-- Greets Andrzej Pruski

[wolph]

I've created a new release that supports your file as well :)