Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 2 classifier #67

Merged
merged 1 commit into from
Aug 21, 2021
Merged

Remove Python 2 classifier #67

merged 1 commit into from
Aug 21, 2021

Conversation

rayluo
Copy link
Contributor

@rayluo rayluo commented Aug 20, 2021

This change should have been included in Portalocker 2.0.0 release. If we removed it at that time, it might have prevented Python 2.x environments from incorrectly pulling in an incompatible Portalocker 2.x and causing failure. (The MSAL Extensions' build pipeline currently runs into such a problem, I'll find a workaround for it, but it would still be good to make the following change here.)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5a23e40 on rayluo:patch-1 into 0f420c8 on WoLpH:develop.

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #67 (5a23e40) into develop (0f420c8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #67   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          209       209           
  Branches        16        16           
=========================================
  Hits           209       209           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f420c8...5a23e40. Read the comment docs.

@wolph
Copy link
Owner

wolph commented Aug 21, 2021

That is indeed silly, thanks for the patch!

@wolph wolph merged commit 8cf8d17 into wolph:develop Aug 21, 2021
@wolph
Copy link
Owner

wolph commented Aug 21, 2021

I've released a new version by the way, so it shouldn't be an issue if you use 2.3.1 or above

@rayluo rayluo deleted the patch-1 branch August 21, 2021 16:40
@rayluo
Copy link
Contributor Author

rayluo commented Aug 21, 2021

Hi Rick, thanks for your quick response and releasing a new version. It turns out, my changes in this PR was only good enough. Sorry for my inexperience on this situation (quoted from here):

Although the list of classifiers is often used to declare what Python versions a project supports, this information is only used for searching & browsing projects on PyPI, not for installing projects. To actually restrict what Python versions a project can be installed on, use the python_requires argument.

Let me know if you want me to send out a new PR for that. I created #69 for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants