Skip to content
This repository has been archived by the owner on Jul 28, 2024. It is now read-only.

[FRNT-507] Implement data table #124

Merged
merged 30 commits into from
Aug 9, 2021
Merged

[FRNT-507] Implement data table #124

merged 30 commits into from
Aug 9, 2021

Conversation

tatinacher
Copy link
Member

Implement data table

  • FRNT-507

@github-actions github-actions bot added @atoms Changes inside atoms @molecules labels May 27, 2021
Irinaristova
Irinaristova reviewed May 28, 2021
View reviewed changes
src/ui/molecules/data-table/filter.tsx Outdated Show resolved Hide resolved
src/ui/molecules/data-table/filter.tsx Outdated Show resolved Hide resolved
src/ui/molecules/data-table/filter.tsx Outdated Show resolved Hide resolved
src/ui/molecules/data-table/filter.tsx Outdated Show resolved Hide resolved
src/ui/molecules/data-table/index.tsx Outdated Show resolved Hide resolved
@tatinacher tatinacher force-pushed the feat/FRNT-507-implement-data-table branch from b39612a to 3bcd4d1 Compare May 31, 2021 09:04
@sergeysova sergeysova removed the @atoms Changes inside atoms label Jun 7, 2021
sergeysova
sergeysova suggested changes Jun 7, 2021
View reviewed changes
src/ui/molecules/data-table/usage.mdx Outdated Show resolved Hide resolved
src/ui/molecules/data-table/usage.mdx Outdated Show resolved Hide resolved
ainursharaev
ainursharaev reviewed Jun 7, 2021
View reviewed changes
Copy link
Contributor

@ainursharaev ainursharaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Посмотрю, как будет сделана фильтрация

@tatinacher
Copy link
Member Author

Посмотрю, как будет сделана фильтрация

В задаче нужно было сделать только DataTable без компонента фильтрации, в дальнейшем как реализуем сам компонент можно будет заменить заглушку Filter.

@tatinacher tatinacher force-pushed the feat/FRNT-507-implement-data-table branch 3 times, most recently from 6f5e883 to 5ee4d59 Compare June 8, 2021 11:07
@tatinacher tatinacher force-pushed the feat/FRNT-507-implement-data-table branch from 5ee4d59 to 7ec29b8 Compare June 16, 2021 10:50
rchubarkin
rchubarkin reviewed Jun 16, 2021
View reviewed changes
src/ui/molecules/data-table/index.tsx Outdated Show resolved Hide resolved
src/ui/molecules/data-table/index.tsx Outdated Show resolved Hide resolved
sergeysova
sergeysova previously requested changes Jun 17, 2021
View reviewed changes
src/ui/molecules/data-table/index.tsx Outdated Show resolved Hide resolved
src/ui/molecules/data-table/index.tsx Outdated Show resolved Hide resolved
src/ui/molecules/data-table/index.tsx Outdated Show resolved Hide resolved
src/ui/molecules/data-table/usage.mdx Outdated Show resolved Hide resolved
@tatinacher tatinacher marked this pull request as draft June 21, 2021 16:16
@tatinacher tatinacher force-pushed the feat/FRNT-507-implement-data-table branch 2 times, most recently from 0dbfd2f to 258a85d Compare June 24, 2021 08:10
@tatinacher tatinacher marked this pull request as ready for review June 24, 2021 08:10
@tatinacher tatinacher force-pushed the feat/FRNT-507-implement-data-table branch from 258a85d to 19df318 Compare June 30, 2021 11:25
Irinaristova
Irinaristova reviewed Jul 6, 2021
View reviewed changes
src/woly/atoms/table/index.tsx Outdated Show resolved Hide resolved
src/woly/atoms/table/index.tsx Show resolved Hide resolved
src/woly/molecules/data-table/filter.tsx Outdated
}

export const RangeCell: React.FC<RangeProps> = ({ value, placeholder }) => (
<span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

мб тут лучше семантичные теги использовать, а не span

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

мб тут лучше семантичные теги использовать, а не span

Это же содержимое ячейки, там должен быть инлайн-текст, нет?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Irinaristova RangeCell это как бы пример того, что будет на проекте, он не включен в экспорты

src/woly/molecules/data-table/filter.tsx Outdated Show resolved Hide resolved
risenforces and others added 14 commits July 19, 2021 16:46
style(data-table): format
3ed8663
refactor(data-table): remove unnecessary variable for placeholder
6489fb1
fix(data-table): replace variant with priority
f00cddb
Merge branch 'master' into feat/FRNT-507-implement-data-table
19a1b01
@Irinaristova @tatinacher
@ainursharaev @rchubarkin
[FRNT-548] Add documentation configurator (#170)
e66ee1c 
* feat(docs): add configurators (+ color configurator)

* style(docs): fix spaces

* style(icons): format

* style: lint styles

* chore: add lint:style:fix command

* perf(configurators): replace heavy libraries

* [FRNT-562] add icon component (#163)

* add icon component

* fix

* fix naming

* fix usage

* fix usage

* [FRNT-559] add toast weight (#165)

* add toast weight

* fix chip and button usage

* fix toast styles

* [FRNT-564] Implement color palette fabrics (#162)

* feat: implement color palette fabrucs

* refactor: remame variable

Co-authored-by: Шараев Айнур Раильевич <mr.sharaevainur@yandex.ru>

* [FRNT-568] add font stacks (#153)

* feat: add system-ui as a fallback font, add a font-weight vars

* feat: move font-stacks to a separate file

* refactor: remove font-weight, rename system font-stack

* refactor: rebase and format

* [FRNT-560] add weight to button-icon (#164)

* add weight to button-icon

* add goast styles

* fix icon-button styles

* [FRNT-396] Rewrite data selectors (#150)

* fix: rewrite data-selector, fix grammar

* feat: write styleguide for data-attribute

* update Styleguide

Co-authored-by: Ira <i.aristova@opends.tech>

* [FRNT-520] Rewrite tooltip (#129)

* chore: bump version (#169)

* feat(docs): add configurators (+ color configurator)

* style(docs): fix spaces

* feat(docs): add white priority to configurators

* refactor(configurators): change layout and color

* chore(deps): update lock

* fix(configurators): hardcoded configurator name

* refactor(configurators): remove unused data-attribute

* refactor(configurators): replace transparency parrent with svg

* refactor(configurators): styling

* style(configurators): remove unnecessary xmlns attribute

* refactor(configurators): styling

* style(configurators): remove unnecessary variables

* style(configurators): remove useless code

* refactor(configurator): stylesheets, simplify and add some comments

* fix(configurators): add viewbox for svg

* refactor(configurators): remove unused refs

* feat(configurators): add scope colors

* feat(configurators): limit the height of configurator's tab

* refactor(configurators): remove unused forwardRef

* fix(configurators): typo

Co-authored-by: Ainur <33234903+purplecandle@users.noreply.github.com>

* refactor(configurators): simplify toggle state

* chore(deps): sync lock

* refactor(configurators): size units

* fix(configurators): remove tertiary priority, add success priority

Co-authored-by: Irina Aristova <38761239+Irinaristova@users.noreply.github.com>
Co-authored-by: tatinacher <tatinacher@gmail.com>
Co-authored-by: Шараев Айнур Раильевич <mr.sharaevainur@yandex.ru>
Co-authored-by: Ainur <33234903+purplecandle@users.noreply.github.com>
Co-authored-by: Ira <i.aristova@opends.tech>
Co-authored-by: rchubarkin <dasasd31@gmail.com>
[FRNT-603] Refactor data-attributes (#181)
1423c86 
* style: change styling data-attributes

* docs(styleguide): update information about data-attributes
@rchubarkin
feat: move all dev stuff from lib to dev dir (#182)
6c5255f
feat(docs): upgrade gatsby theme version (#183)
a07d74f
@rchubarkin
[FRNT-592] feat: implement level decrement (#179)
5528b75 
* feat: implement level decrement

task: FRNT-592

* fix(LevelDecrement): style inner component instead of wrapper

* fix(LevelDecrement): naming

* feat: implement level downgrade

* fix: more specific exported global styles name

* fix(lib): level downgrade better naming
@Irinaristova
[FRNT-543] create tab and tabbar component (#123)
1ed192e 
* create tab ana tabbar component

* fix lint styles

* fix tabs styles

* fix tab styles

* fix shadow

* fix styles

* rewtire styles

* update tabs styles

* fix styles

* update styles

* add weight to tab

* update tab styles

* fix styles

* fix styles
[DS-40] Fix refactored data-icon in box components (#186)
f612621
feat(data-table): improve usage
264b00b
Merge remote-tracking branch 'origin' into feat/FRNT-507-implement-da…
fe8ede3 
…ta-table
fix(table): text color
3c2791e
ainursharaev
ainursharaev previously approved these changes Aug 9, 2021
View reviewed changes
@ainursharaev
fix(data-table): typo
3702f81 
Co-authored-by: Ainur <33234903+purplecandle@users.noreply.github.com>
Irinaristova
Irinaristova previously approved these changes Aug 9, 2021
View reviewed changes
@Irinaristova Irinaristova self-requested a review August 9, 2021 15:15
@risen228 risen228 dismissed sergeysova’s stale review August 9, 2021 15:16

Пофикшено

@risen228 risen228 merged commit 7e21249 into master Aug 9, 2021
@risen228 risen228 deleted the feat/FRNT-507-implement-data-table branch August 9, 2021 15:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ainursharaev ainursharaev ainursharaev approved these changes

@Irinaristova Irinaristova Irinaristova approved these changes

@sergeysova sergeysova Awaiting requested review from sergeysova

@rchubarkin rchubarkin Awaiting requested review from rchubarkin

@risen228 risen228 Awaiting requested review from risen228

Assignees
No one assigned
Labels
@molecules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tatinacher @risen228 @sergeysova @rchubarkin @ainursharaev @Irinaristova