This repository has been archived by the owner on Jul 28, 2024. It is now read-only.
[FRNT-515] Fix table cell vertical position #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,6 +40,8 @@ export const Th = styled.th` | |||
| `; | |||
|
|
|||
| export const Td = styled.td` | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
сорян, не тот скрин прицепила, даже при таком небольшом разрыве в величине выглядит уже не очень
There was a problem hiding this comment.
@Irinaristova тогда мб сделать для шапки таблицы по центру, а для ячеек оставить сверху?
| @@ -28,6 +28,8 @@ export const Tbody = styled.tbody` | |||
| `; | |||
|
|
|||
| export const Th = styled.th` | |||
| display: flex; | |||
| align-items: center; | |||
| box-sizing: border-box; | |||
| max-width: var(--local-cell-max-width); | |||
| padding: var(--local-vertical) var(--local-horizontal); | |||
There was a problem hiding this comment.
мб сразу box добавить?
There was a problem hiding this comment.
мб будем приводить к единому код стайлу - 'data-variant': properties.variant ?? 'secondary' ?
There was a problem hiding this comment.
Думаю это надо в отдельную задачу на доработку таблицы, в этой была задача только отцентрировать по вертикали ячейки
sergeysova
previously approved these changes
Jun 17, 2021
tatinacher
force-pushed
the
feat/FRNT-515-fix-table-cell-vertical-position
branch
from
07fef5d
to
60dd90d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix table cell position to be centered vertical