This repository has been archived by the owner on Jul 28, 2024. It is now read-only.
Add molecule switch
#7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeysova
suggested changes
Aug 17, 2020
src/ui/atoms/checkbox/index.tsx
Outdated
| onChange(event: React.SyntheticEvent): void; | ||
| } | ||
|
|
||
| export const Checkbox: React.FC<CheckboxProps & { className: string }> = ({ |
There was a problem hiding this comment.
Suggested change
| export const Checkbox: React.FC<CheckboxProps & { className: string }> = ({ | |
| const Checkbox: React.FC<CheckboxProps & { className: string }> = ({ |
Думаю, что пользователю не нужен доступ к базовому компоненту без стилей.
Иначе пользователь получит доступ к checkbox.Checkbox и может быть удивлен, почему это верстка расползлась
There was a problem hiding this comment.
@sergeysova сорян, забыла удалить старый Checkbox, компонент лежит в molecules/toggle
tatinacher
force-pushed
the
feat/RBL-262-checkbox
branch
from
1f2aeda
to
756bc4b
Compare
sergeysova
suggested changes
Aug 19, 2020
tatinacher
force-pushed
the
feat/RBL-262-checkbox
branch
from
756bc4b
to
1cff1b6
Compare
sergeysova
approved these changes
Aug 20, 2020
sergeysova
force-pushed
the
feat/RBL-262-checkbox
branch
from
1cff1b6
to
f226fb3
Compare
sergeysova
approved these changes
Aug 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement switch atom