Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update djs to v14 #500

Merged
merged 20 commits into from
Aug 21, 2022
Merged

deps: update djs to v14 #500

merged 20 commits into from
Aug 21, 2022

Conversation

skinmaker1345
Copy link
Contributor

@skinmaker1345 skinmaker1345 commented Aug 15, 2022

Please describe the changes this PR makes and why it should be merged:
This PR includes updating peer deps of djs to v14, thus making Dokdo compatible w/ discord.js v14.

Status

  • Code changes have been tested.

Semantic versioning classification:

  • This PR includes new feature, methods or parameters
  • This PR includes breaking changes (feature, methods, parameters removed or renamed)
  • This PR only includes non-code(typo, documentation etc.) changes

Notes
testing.yml for Github Workflow was changed in favor of the changed dependency.

@wonderlandpark wonderlandpark self-requested a review August 15, 2022 12:16
@wonderlandpark
Copy link
Owner

👋 Thanks for contributing Dokdo!

src/commands/cat.js Outdated Show resolved Hide resolved
src/commands/cat.js Outdated Show resolved Hide resolved
src/commands/curl.js Outdated Show resolved Hide resolved
src/commands/curl.js Outdated Show resolved Hide resolved
src/commands/exec.js Outdated Show resolved Hide resolved
src/commands/jsi.js Outdated Show resolved Hide resolved
src/commands/shard.js Outdated Show resolved Hide resolved
src/commands/shard.js Outdated Show resolved Hide resolved
src/utils/ProcessManager.js Show resolved Hide resolved
src/utils/codeBlock.js Show resolved Hide resolved
@wonderlandpark
Copy link
Owner

  • looks like lock file needs a update (djsv14)

Copy link
Owner

@wonderlandpark wonderlandpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wonderlandpark wonderlandpark merged commit 6076da0 into wonderlandpark:main Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants