Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Woocommerce "Save Settings" button hidden when in debug mode #1

Closed
Trebacz opened this issue Jul 14, 2017 · 4 comments
Closed

Woocommerce "Save Settings" button hidden when in debug mode #1

Trebacz opened this issue Jul 14, 2017 · 4 comments
Assignees

Comments

@Trebacz
Copy link

Trebacz commented Jul 14, 2017

Not sure why the save settings button is hidden when in debug mode.

Unfortunately, this hides the save settings button for all Woocommerce applications until Facebook for Woocommerce is deactivated. If the intention is to hide only for Facebook for WooCommerce, it should probably be handled differently.

Current behavior hides the save settings in all WooCommerce admin and my payment gateways...

@aashay
Copy link
Contributor

aashay commented Jul 14, 2017

Hi David! Thanks for reporting this. We thought we handled it so that it only hides the button for our tab, but if it's hiding it for all tabs, that's a problem. Can you include screenshots/repro steps?

FWIW we're hiding the save button when not in debug mode (you should see it when debug mode is on, along with text fields). The reason for that is simple, if we show the save settings button but not the debug mode text fields, hitting "save" will send empty text to our backend and delete all of your IDs and API key!

We opted to use AJAX instead.

@Trebacz
Copy link
Author

Trebacz commented Jul 14, 2017

No problem it's a fairly easy work around, but it had me scratching my head for awhile. Steps to reproduce:

  1. Put Wordpress in debug mode (define('WP_DEBUG', true); set in wp-config.php)
  2. Go to the Woocommerce "General" tab (or any tab under Woocommerce).
  3. "Save Settings" button missing (also missing on other Woocommerce settings tabs).
  4. Disable "Facebook for WooCommerce".
  5. Return to WooCommerce "General" tab and the blue "Save Settings button is there.
  6. Alternately take the site out of debug mode and the "Sve Settings" button returns.

Desired behavior is that the "Save Settings" button would be enabled for all Woocommerce tabs, except for Facebook for WooCommerce when in debug mode.

facebook for woocommerce - debug mode
facebook for woocommerce - no debug mode

@dmitridr
Copy link
Contributor

dmitridr commented Sep 16, 2017

We've fixed this issue in v1.6.0. Please download the new version and re-open the issue if the problem re-occurs. The new version should be available on the WooCommerce site next week.

@Trebacz
Copy link
Author

Trebacz commented Sep 27, 2017

Thanks for the fix. It works great on 1.6.0 :)

facebook-github-bot pushed a commit that referenced this issue Nov 15, 2018
Summary:
1. Add an ajax function to update custom option.
2. Add a checkbox to mark Dev Environment
3. Bind the checkbox with #1 ajax function
4. Logic to skip the sync when Dev Env flag is marked

Reviewed By: dmitridr

Differential Revision: D13079787

fbshipit-source-id: 9a12febf
@auludag auludag mentioned this issue Nov 19, 2018
deivamagalhaes pushed a commit that referenced this issue May 21, 2020
@Klausdks Klausdks mentioned this issue Aug 3, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants