💅 🏗️ Decrease bundlewatch maxSizes,
#1043
Conversation
Set `index.js` bundle size to 150% of median JS file size from https://httparchive.org/reports/page-weight#bytesJs. Set other `*.js` size, to twice the size of the biggest one.
Upvote for this. Among the planned features I know, there will be a new dependency library to be added from #882. But seems that it could be imported by dependency extraction in WC-admin 2.4.1(included within WC 5.5), so it's not expected to increase the index.js file size much. Refs:
120% should give us a better chance of detecting unusual changes in file size, such as the one found in #821, which we might not have noticed if it had not increased by 2.5 times, but only by 1.5 times. And it gives us a mindset that whether the increase is really in need or reasonable. Even if future features require the maximum size to be increased, it's not a problem at all - just change to the next reasonable value along with that feature PR. 😎 |
Set them to 120% of the biggest file (rounding down).
|
Changed to 120% of the current files: |
Changes proposed in this Pull Request:
Set
index.jsbundle size to 150% of median JS file size fromhttps://httparchive.org/reports/page-weight#bytesJs.
Set other
*.jssize, to twice the size of the biggest one.So we could set more ambitious goals, and get warned/blocked at more proportional change.
IMHO, it's still very forgiving, as we would have to make the biggest JS bundles twice a size to get blocked.
So I'm open to discussion to make those limits even smaller.
Screenshots:
before
after
Detailed test instructions:
Changelog entry