Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @wordpress/scripts to 16.1.3 (from 12.5.0) #821

Closed
wants to merge 3 commits into from

Conversation

tomalec
Copy link
Member

@tomalec tomalec commented Jun 24, 2021

Changes proposed in this Pull Request:

  • Bump @wordpress/scripts to 16.1.3 (from 12.5.0) (2a822dc, 81de5f8)
    Add postcss@8.3.5 as this is required peer dependency.
    Update webpack conf to use the latest version of Sass options.

  • Bump @wordpress/dependency-extraction-webpack-plugin to 3.1.4 from 2.9.0 (9ea9379)

The idea is to reduce our legacy, and hopefully reduce the bundle size by removing IE support.

Screenshots:

Detailed test instructions:

  1. checkout this branch
  2. npm install && npm run build && npm run test-unit && npm run test:e2e

Changelog entry

Tweak - Updated @wordpress/scripts and @wordpress/dependency-extraction-webpack-plugin dependencies.

Additional info

What's really strange and somewhat blocking is that index.js bundle size increased over 2.5 times
image

https://ja2r7.app.goo.gl/CVpKPeNaRRy3Ls5c8

(#819)

Add postcss@8.3.5 as this is required peer dependency.
Update webpack conf to use the latest version of Sass options.
@tomalec tomalec added the type: technical debt This issue/PR represents/solves the technical debt of the project. label Jun 24, 2021
@tomalec tomalec self-assigned this Jun 24, 2021
@eason9487 eason9487 changed the base branch from trunk to develop August 25, 2021 03:26
@tomalec tomalec added the type: technical debt - external devX This issue/PR suffers from the ergonomics of external tools/dependencies label Sep 16, 2021
@tomalec
Copy link
Member Author

tomalec commented Dec 2, 2021

Closing in favor of #1132

@tomalec tomalec closed this Dec 2, 2021
@tomalec tomalec deleted the tweak/bump-wp-scripts branch December 2, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: technical debt - external devX This issue/PR suffers from the ergonomics of external tools/dependencies type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant