Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google/apiclient for PHP 8.3 compatibility #2194

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

mikkamp
Copy link
Contributor

@mikkamp mikkamp commented Jan 8, 2024

Changes proposed in this Pull Request:

This PR upgrades the google/apiclient packages and dependencies to resolve the last PHP 8.3 deprecation notice:

[08-Jan-2024 11:50:31 UTC] PHP Deprecated:  Calling get_class() without arguments is deprecated in google-listings-and-ads/vendor/google/apiclient/src/Http/REST.php on line 58

The notice was resolved in google/apiclient version 2.15.2

Packages upgraded:

composer update google/apiclient --with-all-dependencies

- Upgrading firebase/php-jwt (v6.9.0 => v6.10.0)
- Upgrading google/apiclient (v2.15.1 => v2.15.3)
- Upgrading google/apiclient-services (v0.323.0 => v0.331.0)
- Upgrading google/auth (v1.32.1 => v1.34.0)
- Upgrading guzzlehttp/guzzle (7.8.0 => 7.8.1)
- Upgrading guzzlehttp/promises (2.0.1 => 2.0.2)
- Upgrading guzzlehttp/psr7 (2.6.1 => 2.6.2)
- Upgrading phpseclib/phpseclib (3.0.33 => 3.0.35)

Closes #2182

Detailed test instructions:

  1. Install extension on a site with PHP 8.3 and WP_DEBUG logging enabled
  2. View the page Marketing > Google Listings & Ads (after being onboarded)
  3. Confirm we don't get any deprecation notices logged

Changelog entry

  • Update - Upgrade google/apiclient for PHP 8.3 compatibility.

@mikkamp mikkamp self-assigned this Jan 8, 2024
@github-actions github-actions bot added the changelog: update Big changes to something that wasn't broken. label Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (acf6ae5) 59.4% compared to head (55618c5) 59.4%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             develop   #2194   +/-   ##
=========================================
  Coverage       59.4%   59.4%           
  Complexity      4127    4127           
=========================================
  Files            453     453           
  Lines          16478   16478           
=========================================
  Hits            9788    9788           
  Misses          6690    6690           
Flag Coverage Δ
php-unit-tests 59.4% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mikkamp mikkamp requested a review from a team January 8, 2024 15:28
Copy link
Contributor

@martynmjones martynmjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mikkamp, thanks for the update!

Tested with PHP 8.3.0 and confirmed that no deprecation notices are displayed so LGTM ✅

@mikkamp mikkamp merged commit 02ecfa3 into develop Jan 9, 2024
12 checks passed
@mikkamp mikkamp deleted the update/2182-php-8-3-compat branch January 9, 2024 09:19
@tomalec tomalec mentioned this pull request Jan 10, 2024
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: update Big changes to something that wasn't broken.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.3 Compatibility
2 participants