Update doc links references to google-for-woocommerce #2486
Conversation
github-actions
bot
added
the
changelog: tweak
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2486 +/- ##
===========================================
+ Coverage 64.5% 64.6% +0.1%
- Complexity 4564 4575 +11
===========================================
Files 795 797 +2
Lines 22844 22898 +54
Branches 1220 1220
===========================================
+ Hits 14739 14793 +54
Misses 7938 7938
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Thanks for the changes, I only found one location where we might want to change a link.
The rest are comments more related to the documentation itself, so we might need to follow up in a different location to get those changed. I also noticed that the breadcrumbs isn't very consistent:
| @@ -21,7 +21,7 @@ import './request-full-access-google-account-card.scss'; | |||
| * @param {string} props.additionalScopeEmail Specify the email to be requested additional permission scopes to Google. | |||
| * @fires gla_google_account_connect_button_click with `{ action: 'scope', context: 'reconnect' }` | |||
| * @fires gla_google_account_connect_button_click with `{ action: 'scope', context: 'setup-mc' }` | |||
| * @fires gla_documentation_link_click with `{ context: 'setup-mc-accounts', link_id: 'required-google-permissions', href: 'https://woocommerce.com/document/google-listings-and-ads/#required-google-permissions' }` | |||
| * @fires gla_documentation_link_click with `{ context: 'setup-mc-accounts', link_id: 'required-google-permissions', href: 'https://woocommerce.com/document/google-for-woocommerce/get-started/requirements/#general-requirements' }` | |||
There was a problem hiding this comment.
Are we sending them to the right link here when they haven't accessed all scopes?
What about using https://woocommerce.com/document/google-for-woocommerce/get-started/setup-and-configuration/#required-google-permissions
There was a problem hiding this comment.
I agree. Changed here 679db10
| @@ -23,7 +23,7 @@ import StoreAddressCard from '.~/components/contact-information/store-address-ca | |||
|
|
|||
| const learnMoreLinkId = 'contact-information-read-more'; | |||
| const learnMoreUrl = | |||
| 'https://woocommerce.com/document/google-listings-and-ads/#contact-information'; | |||
| 'https://woocommerce.com/document/google-for-woocommerce/get-started/requirements/#contact-information'; | |||
There was a problem hiding this comment.
I don't know how valid this link is for the store address. This also adds the store address to the Merchant Account, but isn't made public. This also doesn't fulfil the public contact information requirement.
I think we need to either separate the contact information section into two parts or include a mention about the contact address and phone number being added to the Merchant Center account.
The two separate parts would be:
- Contact information synced with Merchant account (phone + store address)
- Requirement to have at least one type of public contact information on your site (contact us page)
Should the second part be on the compliance policy page: https://woocommerce.com/document/google-for-woocommerce/compliance-policy-2
There was a problem hiding this comment.
Hi @mikkamp Not sure if I fully understand this. Can you elaborate?
There was a problem hiding this comment.
I meant because it's mixing both contact details that should be on your site and public and then also contact details which should be sent to Merchant Center it's a bit confusing what part belongs to this learnMore link. But reading it again, it does still provide the required information so maybe we can just leave it for now.
I don't think we can change that in this PR so I will ping for updating the docs. |
Changes proposed in this Pull Request:
This PR replaces all the links pointing into
https://woocommerce.com/document/google-listings-and-ads,https://woocommerce.com/document/google-for-woocommercetoList of URLs Changed
https://woocommerce.com/document/google-listings-and-ads/#required-google-permissions (works in Old, anchor stop working in New)
Its now a new page here. https://woocommerce.com/document/google-for-woocommerce/get-started/requirements/#general-requirements
https://woocommerce.com/document/google-listings-and-ads/#contact-information (works in Old, anchor stop working in New)
Updated link :- https://woocommerce.com/document/google-for-woocommerce/get-started/requirements/#contact-information
https://woocommerce.com/document/google-listings-and-ads/#general-requirements (works in Old, anchor stop working in New)
updated link :- https://woocommerce.com/document/google-for-woocommerce/get-started/requirements/#general-requirements
https://woocommerce.com/document/google-listings-and-ads/#google-performance-max-campaigns (works in Old, anchor stop working in New)
It's a new page now. https://woocommerce.com/document/google-for-woocommerce/get-started/google-performance-max-campaigns/
https://woocommerce.com/document/google-listings-and-ads/#google-merchant-center-requirements (works in Old, anchor stop working in New)
updated link :- https://woocommerce.com/document/google-for-woocommerce/get-started/requirements/#google-merchant-center-requirements
https://woocommerce.com/document/google-listings-and-ads/#free-listings-on-google (works in Old, anchor stop working in New)
New page is here. https://woocommerce.com/document/google-for-woocommerce/get-started/product-feed-information-and-free-listings/#section-1
Has a new page https://woocommerce.com/document/google-for-woocommerce/get-started/campaign-analytics/
New page is here. https://woocommerce.com/document/google-for-woocommerce/compliance-policy-2/
updated Link is here. https://woocommerce.com/document/google-for-woocommerce/compliance-policy-2/#store-is-live
updated link is here https://woocommerce.com/document/google-for-woocommerce/compliance-policy-2/#complete-checkout
updated link is here. https://woocommerce.com/document/google-for-woocommerce/compliance-policy-2/#refund-and-terms
New page is here. https://woocommerce.com/document/google-for-woocommerce/faq/
Detailed test instructions:
https://woocommerce.com/document/google-listings-and-adsAdditional details:
Changelog entry