Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bundlewatch/bundlewatch to dev dependencies. #819

Merged
merged 3 commits into from
Jul 7, 2021
Merged

Add bundlewatch/bundlewatch to dev dependencies. #819

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ab5cf8
Add `bundlewatch/bundlewatch` to dev dependencies.
tomalec Jun 24, 2021
9c42641
Merge branch 'trunk' into add/818-bundlewatch
tomalec Jul 7, 2021
ed9cbc7
Add bundlewatch to .travis.yml
tomalec Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,12 @@ matrix:
- name: "Coding standard check"
php: 7.4
env: WP_VERSION="${WP_LATEST}" WC_VERSION="${WC_LATEST}" WP_TRAVISCI=cs WP_MULTISITE=0
script: npm ci && npm run lint
script: npm run lint
- name: "Bundle size"
php: 7.4
env: WP_VERSION="${WP_LATEST}" WC_VERSION="${WC_LATEST}" WP_TRAVISCI=cs WP_MULTISITE=0
# We run the production build, to watch also .zip size.
script: npm run build && npx bundlewatch

before_install:
- if [[ "${WP_TRAVISCI}" != "jest" ]]; then composer self-update --1; fi
Expand Down
11 changes: 7 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,25 +95,28 @@
"files": [
{
"path": "./js/build/*.js",
"maxSize": "2 kB"
"maxSize": "3 kB"
},
{
"path": "./js/build/index.js",
"maxSize": "1 mB"
"maxSize": "3 mB"
},
{
"path": "./js/build/*.css",
"maxSize": "1 kB"
},
{
"path": "./js/build/index.css",
"maxSize": "8 kB"
"maxSize": "10 kB"
},
{
"path": "./google-listings-and-ads.zip",
"maxSize": "12 mB",
"compression": "none"
}
]
],
"ci": {
"trackBranches": ["trunk", "develop"]
}
Comment on lines +118 to +120
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomalec , just noticed this, really minor nitpick: the three lines here are using space indentation instead of tabs like other lines. 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd address it in #869

}
}