Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the phpcs-diff action to use Node.js v20 #116

Conversation

eason9487
Copy link
Member

@eason9487 eason9487 commented Apr 24, 2024

Changes proposed in this Pull Request:

Part of #108

This PR upgrades the phpcs-diff action to use Node.js v20

📌 Checklist before merging (@eason9487)

  • Revert 3bba1ed before merging this PR

Detailed test instructions:

  1. View a previous workflow run used v1 phpcs-diff action
  2. View a test workflow run used updated phpcs-diff action
  3. View the test PR
    • woocommerce/automatewoo-birthdays/pull/134
    • The annotations are shown
      image
      image

@eason9487 eason9487 requested a review from a team April 24, 2024 07:58
@eason9487 eason9487 self-assigned this Apr 24, 2024
Copy link
Contributor

@mikkamp mikkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

I confirmed the warnings are there in previous runs, and no longer present in the latest run. I don't see any other references which need to be changed for this action.

Base automatically changed from update/108-nodejs-v20-root-deps to update/108-nodejs-v20 April 25, 2024 02:58
@eason9487 eason9487 merged commit 682cc86 into update/108-nodejs-v20 Apr 25, 2024
@eason9487 eason9487 deleted the update/108-nodejs-v20-github-actions-phpcs-diff branch April 25, 2024 03:03
@eason9487 eason9487 mentioned this pull request Apr 25, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants