Skip to content
This repository has been archived by the owner on Jun 7, 2022. It is now read-only.

DatePicker: Viewport oddities #252

Closed
psealock opened this issue Jul 30, 2018 · 3 comments · Fixed by #280
Closed

DatePicker: Viewport oddities #252

psealock opened this issue Jul 30, 2018 · 3 comments · Fixed by #280
Assignees
@timmyc
Labels
focus: analytics Issues about Analytics/Reports focus: components Issues for woocommerce components type: bug The issue is a confirmed bug.

Comments

@psealock
Copy link
Collaborator

psealock commented Jul 30, 2018 •
edited

From #239 (comment)

I'm still seeing a bit of oddness with the same issue I described above. Almost seems like my viewport height is at some in-between spot that is preventing the scrolling from happening. If I shrink the viewport a smidge, it works as expected.

To reproduce:

  1. /wp-admin/admin.php?page=wc-admin#/analytics/products
  2. Open the datepicker
  3. Shrink the viewport to just the height of the datepicker
  4. Switch to Custom tab, which is longer than the Presets tab
  5. See the scrollbars don't appear and the bottom of the datepicker is inaccessible
This was referenced Jul 30, 2018
Merged
Closed
@timmyc
Copy link
Contributor

timmyc commented Jul 30, 2018

z-index-jank

z-index issue can be seen in the screenshot above.

@timmyc timmyc added this to ☎️ Sprint 2 Backlog in Isotope Jul 30, 2018
@timmyc timmyc added type: bug The issue is a confirmed bug. focus: analytics Issues about Analytics/Reports labels Jul 30, 2018
@timmyc timmyc mentioned this issue Aug 7, 2018
Merged
@timmyc timmyc self-assigned this Aug 7, 2018
Isotope automation moved this from ☎️ Sprint 2 Backlog to ☎️Sprint 2 Done Aug 8, 2018
@psealock psealock changed the title DatePicker: Viewport and z-index oddities DatePicker: Viewport oddities Aug 13, 2018
@psealock
Copy link
Collaborator Author

I'm reopening this issue because only the z-index issue was resolved. The viewport on Popover not responding to content height issue remains.

@psealock psealock reopened this Aug 13, 2018
This was referenced Aug 13, 2018
Merged
Merged
@timmyc timmyc removed this from ☎️Sprint 2 Done in Isotope Aug 31, 2018
@timmyc timmyc added this to 🐭 Sprint 3 Backlog in Isotope Aug 31, 2018
@ryelle ryelle added the focus: components Issues for woocommerce components label Sep 6, 2018
@timmyc
Copy link
Contributor

timmyc commented Sep 13, 2018

Since this is blocked upstream I'm moving this to the project backlog.

@timmyc timmyc moved this from 👻Sprint 3 Backlog to Project Backlog 🔙 in Isotope Sep 13, 2018
Isotope automation moved this from Project Backlog 🔙 to Sprint 4 Done Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@timmyc timmyc

Labels
focus: analytics Issues about Analytics/Reports focus: components Issues for woocommerce components type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Header: Set z-index greater than popover woocommerce/woocommerce-admin
3 participants
@timmyc @ryelle @psealock