Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Filters: Simplify options #1748

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Filters: Simplify options #1748

merged 1 commit into from
Mar 6, 2019

Conversation

psealock
Copy link
Collaborator

@psealock psealock commented Mar 6, 2019

Fixes #1678
Fixes #1680

  • Remove "Top *" from filters list for Coupons, Products, Categories, and Variations Reports.
  • Remove "Single Category" and "Category Comparison" filters from Products Report.

The Categories Report uses the /products/stats endpoint under the hood. Since the Product Report had category related filters, the resulting filter query used them, but now it must use the Category filters config, so some endpoint mapping was required.

Detailed test instructions:

  1. Coupons, Products, Categories, and Variations Reports should no longer have "Top *" options in the Show menu. For example, Top Categories by Items Sold will no longer be there.
  2. Ensure Single Category" and "Category Comparison" filters from Products Report are no longer available but are on the Categories Report.
  3. Check that links to categories from other reports do not point to the Products Report.

@psealock psealock added [Status] Needs Review type: task The issue is an internally driven task (e.g. from another A8c team). focus: analytics Issues about Analytics/Reports labels Mar 6, 2019
Copy link
Contributor

@joshuatf joshuatf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean- LGTM! 👍

@psealock psealock merged commit ff3beb8 into master Mar 6, 2019
@psealock psealock deleted the update/adv-filters-show branch March 6, 2019 21:45
@LevinMedia
Copy link
Contributor

LevinMedia commented Mar 6, 2019

heya @psealock I noticed a bug here:

when switching from "All" to "Comparison", it automatically changes the chart to comparison mode:

screen recording 2019-03-06 at 02 31 pm

that shouldn't happen until a user has selected at least two things and clicks compare.

@LevinMedia
Copy link
Contributor

Also noting the first portion of #1680 was missing from this PR. When viewing a single product category in the category report, you should see a list of all it's child products.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: analytics Issues about Analytics/Reports type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants