Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orders report now shows coupons in Coupon(s) column #2812

Merged
merged 2 commits into from Aug 20, 2019

Conversation

@cojennin
Copy link
Contributor

commented Aug 19, 2019

Fixes #2745

With this PR, the Orders report will now show coupons in the "Coupon(s)" column.

Screenshots

Screen Shot 2019-08-19 at 12 47 26 PM

Screen Shot 2019-08-19 at 12 47 39 PM

Detailed test instructions:

  • Go to Orders report
  • Click on Download
  • Open the CSV report
  • Coupon data in the report now displayed in Dashboard and CSV

@cojennin cojennin changed the title CSV download of Orders now shows coupons in Coupon(s) column Orders report now shows coupons in Coupon(s) column Aug 19, 2019

@joshuatf
Copy link
Contributor

left a comment

Thanks for this PR, @cojennin!

This is testing well. One tiny change and I think this is good to merge.

client/analytics/report/orders/table.js Outdated Show resolved Hide resolved
Update client/analytics/report/orders/table.js
Co-Authored-By: Joshua T Flowers <joshuatf@gmail.com>

@rrennick rrennick added this to In Progress PRs (for automation purposes) in wc-admin via automation Aug 20, 2019

@rrennick
Copy link
Collaborator

left a comment

@cojennin Thanks for your contribution.

@rrennick rrennick merged commit a23ef44 into woocommerce:master Aug 20, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

wc-admin automation moved this from In Progress PRs (for automation purposes) to Done Sprint 23 (August 13 - August 26) Aug 20, 2019

@cojennin cojennin deleted the cojennin:fix/2745-csv-coupons branch Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.