Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Orders report now shows coupons in Coupon(s) column #2812

Merged
merged 2 commits into from
Aug 20, 2019

Conversation

cojennin
Copy link
Contributor

Fixes #2745

With this PR, the Orders report will now show coupons in the "Coupon(s)" column.

Screenshots

Screen Shot 2019-08-19 at 12 47 26 PM

Screen Shot 2019-08-19 at 12 47 39 PM

Detailed test instructions:

  • Go to Orders report
  • Click on Download
  • Open the CSV report
  • Coupon data in the report now displayed in Dashboard and CSV

@cojennin cojennin changed the title CSV download of Orders now shows coupons in Coupon(s) column Orders report now shows coupons in Coupon(s) column Aug 19, 2019
Copy link
Contributor

@joshuatf joshuatf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @cojennin!

This is testing well. One tiny change and I think this is good to merge.

client/analytics/report/orders/table.js Outdated Show resolved Hide resolved
Co-Authored-By: Joshua T Flowers <joshuatf@gmail.com>
@rrennick rrennick added [Status] Needs Review type: bug The issue is a confirmed bug. focus: analytics Issues about Analytics/Reports labels Aug 20, 2019
Copy link
Collaborator

@rrennick rrennick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cojennin Thanks for your contribution.

@rrennick rrennick merged commit a23ef44 into woocommerce:master Aug 20, 2019
@cojennin cojennin deleted the fix/2745-csv-coupons branch August 20, 2019 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: analytics Issues about Analytics/Reports type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSV Report doesn't show Coupon data
3 participants