Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

display local time on note instead of UTC #2818

Merged
merged 1 commit into from
Aug 23, 2019
Merged

display local time on note instead of UTC #2818

merged 1 commit into from
Aug 23, 2019

Conversation

rrennick
Copy link
Collaborator

Fixes #2006

This PR changes the notes display date prop from date_created_gmt to
date_created.

Detailed test instructions:

  • Update the date_created on an actionable note to the current time UTC
    update wp_wc_admin_notes set date_created = '2019-08-20 20:29:57' where note_id = 1234;
  • Set you WP install to UTC-4 (America/New York)
  • Open the notes panel
  • The updated note will say 4 hours from now
  • Switch to this PR
  • The updated note will say Now

Changelog Note:

Fix: Date calculation on notes being double adjusted to UTC.

@rrennick rrennick added [Status] Needs Review type: bug The issue is a confirmed bug. focus: inbox Issues related to inbox notifications labels Aug 20, 2019
@rrennick rrennick requested a review from a team August 20, 2019 22:49
Copy link
Collaborator

@psealock psealock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rrennick This is testing well for me in a variety of scenarios.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: inbox Issues related to inbox notifications type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activity Panel: Notes timezone issues
2 participants