Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display local time on note instead of UTC #2818

Merged
merged 1 commit into from Aug 23, 2019

Conversation

@rrennick
Copy link
Collaborator

commented Aug 20, 2019

Fixes #2006

This PR changes the notes display date prop from date_created_gmt to
date_created.

Detailed test instructions:

  • Update the date_created on an actionable note to the current time UTC
    update wp_wc_admin_notes set date_created = '2019-08-20 20:29:57' where note_id = 1234;
  • Set you WP install to UTC-4 (America/New York)
  • Open the notes panel
  • The updated note will say 4 hours from now
  • Switch to this PR
  • The updated note will say Now

Changelog Note:

Fix: Date calculation on notes being double adjusted to UTC.

@rrennick rrennick added this to In Progress PRs (for automation purposes) in wc-admin via automation Aug 20, 2019

@rrennick rrennick requested a review from woocommerce/wc-admin Aug 20, 2019

@psealock
Copy link
Collaborator

left a comment

Thanks @rrennick This is testing well for me in a variety of scenarios.

@rrennick rrennick merged commit 46c66a8 into master Aug 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

wc-admin automation moved this from In Progress PRs (for automation purposes) to Done Sprint 23 (August 13 - August 26) Aug 23, 2019

@rrennick rrennick deleted the fix/2006 branch Aug 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.