Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Fix downloads report #5441

Merged
merged 3 commits into from
Oct 27, 2020
Merged

Fix downloads report #5441

merged 3 commits into from
Oct 27, 2020

Conversation

becdetat
Copy link
Contributor

This is a copy of #5321, a PR from @sultann. I've copied it to:

  • get CI building the branch
  • change prepare_item_for_export to use $export_item to match other controllers

Note that I've tested @sultann's PR, this just needs approval for merging.

Detailed test instructions:

  • Unless you have several hundred downloads this will be impossible to test
  • The easiest way to see what happens with the typo is to introduce it to /src/API/Reports/Orders/Controller.php and run a orders download. The error log should fill up with errors and the downloaded report (emailed) will be full of empty lines.

@jeffstieler jeffstieler merged commit 9b95f2b into main Oct 27, 2020
@jeffstieler jeffstieler deleted the fix-downloads-report-sultann branch October 27, 2020 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants