Home Screen - Changed activity panel button styles

[octaedro]

This PR is a follow-up of the PR 5455, so a rebase will be necessary.

This PR changes the styles of the panel button "Manage all orders".

Screenshots

Detailed test instructions:

• Go to the Home screen.
• Verify the button Manage all orders inside the Orders panel is visible.
• Press Manage all orders and verify it's working as expected.

Changelog Note:

Dev: Home Screen - Changed activity panel button styles

[samueljseay]

@octaedro Just a thought that if you change this branch to be merging into #5455 instead of main then its easy to review the individual changes without any rebasing.

Then once both are approved just merge them starting with this one and then finishing with the other one.

[octaedro]

Hi @samueljseay,

@octaedro Just a thought that if you change this branch to be merging into #5455 instead of main then its easy to review the individual changes without any rebasing.

Good question. A few months ago, I tried the approach you mentioned but the reviewers felt that it would have been easier to review if we created the branches from the depending branch and pointing to main. I think that each approach has its own pros and cons.
I'm not sure if it's helpful but with an URL like this you can see in the browser the difference between two chosen PRs.

[octaedro]

Hi @samueljseay,

Chatting with @jeffstieler he said that chaining PRs work better for him too so I'll change the base of this and the other PRs

[jeffstieler]

@octaedro this doesn't seem to match the design:

Am I referencing the wrong design?

[jeffstieler]

I wonder how much value the ActivityOutboundLink component really has... this is the only usage of it. Why don't we just get rid of it?

[samueljseay]

Looking at the fact that you're adding more code to this unused component to remove the icon rendering I agree that ditching it has some value here. It has a bit of styling associated with it, but that styling could just move to a class name on a <Link> that you render here instead? It would be great to keep removing unused code to trim the code base down.

[octaedro]

Good idea! I changed it in the commit 57ae4f5

[octaedro]

Hi @jeffstieler,

I know it's a little confusing, I think that the latest designs are here pbIJXs-ma-p2#comment-1017.

[jeffstieler]

Sheesh, I was in Figma and on a different iteration. 🤦

[samueljseay]

Keen to see what you think about removing that component.

[samueljseay]

Looking at the fact that you're adding more code to this unused component to remove the icon rendering I agree that ditching it has some value here. It has a bit of styling associated with it, but that styling could just move to a class name on a <Link> that you render here instead? It would be great to keep removing unused code to trim the code base down.

[octaedro]

Thank you @jeffstieler and @samueljseay for your reviews. I addressed the change you mentioned.
Could you give this PR another look?

[samueljseay]

Great stuff @octaedro tests well and the code looks great. Thanks for removing that old component! 🧹 🚀