This repository has been archived by the owner on Jun 7, 2022. It is now read-only.
Add changelog and enable promotion in core and plugin configs #7666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs changelog entry
and removed
needs changelog entry
labels
louwie17
added
the
status: blocked
louwie17
force-pushed
the
update/7319_enable_wc_pay_experiment
branch
from
845aeee
to
36639a2
Compare
louwie17
added
status: needs review
and removed
status: blocked
mattsherman
approved these changes
Sep 24, 2021
| Significance: minor | ||
| Type: Enhancement | ||
|
|
||
| Adds experiment for promoting wcpay in payment methods table. #7666 |
There was a problem hiding this comment.
Should we spell out WooCommerce Payments in this changelog entry?
There was a problem hiding this comment.
Also very nitpicky and something we aren't consistent on is verb tense in changelogs.
joshuatf
approved these changes
Sep 24, 2021
| Significance: minor | ||
| Type: Enhancement | ||
|
|
||
| Adds experiment for promoting wcpay in payment methods table. #7666 |
There was a problem hiding this comment.
Also very nitpicky and something we aren't consistent on is verb tense in changelogs.
…ot defined defaulting to 'yes'
joshuatf
reviewed
Sep 27, 2021
| */ | ||
| public static function evaluate( $spec ) { | ||
| $rule_evaluator = new RuleEvaluator(); | ||
| $suggestion = (object) $spec; | ||
| $suggestion = is_array( $spec ) ? (object) $spec : clone $spec; |
There was a problem hiding this comment.
I can't remember if this works in PHP or not, but can we clone and coerce to an object at the same time?
Suggested change
| $suggestion = is_array( $spec ) ? (object) $spec : clone $spec; | |
| $suggestion = clone (object) $spec; |
There was a problem hiding this comment.
Yeah we could do that, this would technically cause a array to be cloned twice (in essence), creating a new object out of it first and then cloning that new object.
There was a problem hiding this comment.
Ah, good point. Let's leave it as is.
ObliviousHarmony
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Mar 18, 2022
…merce/woocommerce-admin#7666) * Add changelog and enable promotion in core and plugin configs * Add PR number * Make variation name a constant * Clone spec as we are overwriting the is_visible prop * Fix unit tests and support array and object * Revert explat variation name * Update changelog entry * Update changelog once more * Make sure the recommendations show up if marketplace suggestions is not defined defaulting to 'yes'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7319
This is the final change enabling the feature in all environments.
I will also generate a zip after the above merge for easier testing on Jurassic.
Previous PRs:
#7550
#7553
#7554
Screenshots
Detailed test instructions:
*once the above PR is merged this might only work with Jetpack enabled (so I thought) the actual experiment is still in staging so it might not work. Instead you can test with this zip - woocommerce-admin.zip, which uses the
explat_test_v4_woocommerce_wc_pay_promotion_payment_methods_table_v1experiment, which is active.woocommerce_wc_pay_promotion_payment_methods_table_v1and grab the treatment bookmarklet (save it to your bookmarks tab) with the above zip, grab the treatment bookmarklet from this experiment instead:explat-test-v4-woocommerce-wc-pay-promotion-payment-methods-table-v1(ping me for the link as you can find it in Abacus)controlvariation, which would make the WC Pay not show up in the payment method table, but in the recommended card instead.Note: This might require a new site as the experiment variation is saved in a transient.