Skip to content
This repository has been archived by the owner on Jun 7, 2022. It is now read-only.

Add changelog and enable promotion in core and plugin configs #7666

Merged
merged 9 commits into from Sep 27, 2021
Merged

Add changelog and enable promotion in core and plugin configs #7666

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
547a2bb
Add changelog and enable promotion in core and plugin configs
louwie17 Sep 15, 2021
36639a2
Add PR number
louwie17 Sep 15, 2021
3069421
Make variation name a constant
louwie17 Sep 23, 2021
982a46a
Clone spec as we are overwriting the is_visible prop
louwie17 Sep 24, 2021
b613cad
Fix unit tests and support array and object
louwie17 Sep 24, 2021
9d43ed3
Revert explat variation name
louwie17 Sep 24, 2021
a47f04a
Update changelog entry
louwie17 Sep 27, 2021
115862e
Update changelog once more
louwie17 Sep 27, 2021
0aacbdf
Make sure the recommendations show up if marketplace suggestions is n…
louwie17 Sep 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelogs/update-7319_enable_wc_pay_experiment
View file
Open in desktop
@@ -0,0 +1,4 @@
Significance: minor
Type: Enhancement

Adds experiment for promoting wcpay in payment methods table. #7666
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we spell out WooCommerce Payments in this changelog entry?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also very nitpicky and something we aren't consistent on is verb tense in changelogs.

2 changes: 1 addition & 1 deletion config/core.json
View file
Open in desktop
Expand Up @@ -18,6 +18,6 @@
"store-alerts": true,
"tasks": false,
"transient-notices": true,
"wc-pay-promotion": false
"wc-pay-promotion": true
}
}
2 changes: 1 addition & 1 deletion config/plugin.json
View file
Open in desktop
Expand Up @@ -18,6 +18,6 @@
"store-alerts": true,
"tasks": false,
"transient-notices": true,
"wc-pay-promotion": false
"wc-pay-promotion": true
}
}
3 changes: 2 additions & 1 deletion src/Features/WcPayPromotion/Init.php
View file
Open in desktop
Expand Up @@ -16,6 +16,7 @@
*/
class Init {
const SPECS_TRANSIENT_NAME = 'woocommerce_admin_payment_method_promotion_specs';
const EXPLAT_VARIATION_PREFIX = 'woocommerce_wc_pay_promotion_payment_methods_table_';

/**
* Constructor.
Expand Down Expand Up @@ -113,7 +114,7 @@ public static function should_register_pre_install_wc_pay_promoted_gateway() {
$allow_tracking
);

$variation_name = $abtest->get_variation( 'woocommerce_wc_pay_promotion_payment_methods_table_' . $wc_pay_spec->additional_info->experiment_version );
$variation_name = $abtest->get_variation( self::EXPLAT_VARIATION_PREFIX . $wc_pay_spec->additional_info->experiment_version );

if ( 'treatment' === $variation_name ) {
return true;
Expand Down