This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
Add an endpoint and method for actioning tasks #7746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louwie17
reviewed
Oct 5, 2021
| } ); | ||
|
|
||
| yield actionTaskSuccess( | ||
| possiblyPruneTaskData( task, [ 'isDismissed', 'isSnoozed' ] ) |
There was a problem hiding this comment.
Ooh one comment I forgot, we should only list isActioned in this array, you can remove the isDismissed and isSnoozed.
cc @joshuatf
ObliviousHarmony
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Mar 18, 2022
…ce-admin#7746) * Add checks for actioned task status * Update completion logic for task * Add rest route for actioning tasks * Add action in data store for actioning tasks * Add test for actioning task * Only prune isActioned from task data
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7742
Adds an endpoint for actioning tasks.
Also fixes up Marketing completion logic.
Screenshots
Detailed test instructions:
woocommerce_task_list_tracked_completed_actionsoption.woocommerce_task_list_tracked_completed_actionscontains an array withmarketing.woocommerce_task_list_tracked_completed_actionsoption.