This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
Reduce padding around plugin list titles for marketing tools page. #8171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Small padding change. I'm particularly interested in from the creator of the issue, @ilyasfoo. |
ilyasfoo
approved these changes
Jan 17, 2022
There was a problem hiding this comment.
Thanks, @jacob-sewell! I've looked at it and I think gap-large for top looks a tad better.
Pre-approving! 🍏
Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>
|
@jacob-sewell Do we need another review on this, or is it ready to be merged? |
No, it's ready, I just hadn't noticed I finally had enough passing tests. |
jacob-sewell
deleted the
fix/8164-padding-reduction-reach-out-to-customers
branch
ObliviousHarmony
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Mar 18, 2022
…oocommerce/woocommerce-admin#8171) * Reduce padding around plugin list titles for marketing tools page. * Changelog for 8164/8171. * Update plugin list title padding Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com> Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8164
Reduce padding around plugin list titles for marketing tools page. (In the screenshots below, we're talking about "Reach out to customers" and "Grow your store".)
Screenshots
Before:
After:
Detailed test instructions: