Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Product List screen doesn't refresh the "No products available" placeholder state #3046

Closed
3 tasks done
AliSoftware opened this issue Oct 19, 2020 · 1 comment
Closed
3 tasks done
Labels
feature: product list Related to the product list. type: bug A confirmed bug.

Comments

@AliSoftware
Copy link
Contributor

AliSoftware commented Oct 19, 2020

Describe the bug

The "No Products Available" placeholder is still visible after creating a product and going back to the products page listing the new product. Pull to refresh fixes it by making it disappear. Likewise, when there's a product in the list and you edit it to change its status (and making it filtered out from the list) and go back, the "No Products Available" placeholder is not visible until pull to refresh

To Reproduce

  • Go on the "Products" tab and make this list empty (either use a filter with no results, or start with a brand new store empty of any product). We see "No products found", as expected;
  • Tap on + to add a product, and fill the details
  • Go back (either publish the product then go back, or go back and choose save the product as draft) and land on the Products page again
  • We see both the newly created product in the list… and still the "No products found" placeholder, which is confusing
  • Pull-to-refresh solves this and makes the "No products found" disappear now that there's one product in the list
  • Likewise when editing a product to change its state then go back on the product list (on which a filter was applied, making the list empty now that there's no matching product), the "No products found" is not shown on the empty list screen until we pull-to-refresh

Screenshots

0-EmptyList-OK 1-NewProduct-ButAlsoBanner 2-ChangingProductStatusThenGoBack-NoBanner
Initial view: OK ✅ After adding a new product then hit back 🐞 After changing the state of a product then hit back 🐞

Expected behavior

The "No Products Available" placeholder visibility state should be refreshed when we go back to that screen

Isolating the problem:

  • I have deactivated other plugins and confirmed this bug occurs when only WooCommerce plugin is active.
  • This bug happens with a default WordPress theme active, or Storefront.
  • I can reproduce this bug consistently using the steps above.

Mobile Environment

Please include:

  • Device: Pixel 2 API 30 emulator and Galaxy S20 physical device
  • Android version: API 30 (emulator), Android 10 (S20)
  • WooCommerce Android version: 5.2.0.2 (from release branch)
@AliSoftware AliSoftware added type: bug A confirmed bug. feature: product list Related to the product list. labels Oct 19, 2020
@shiki shiki added this to Needs Triage in Continuous Improvements via automation Oct 19, 2020
@shiki shiki added this to To do in Add/Edit Products release 5 via automation Oct 19, 2020
@anitaa1990 anitaa1990 removed this from Needs Triage in Continuous Improvements Oct 21, 2020
@anitaa1990 anitaa1990 added this to To do in Add/Edit Products release 4 via automation Oct 21, 2020
@anitaa1990 anitaa1990 moved this from To do to Bug/Crashes/Small enhancements in Add/Edit Products release 4 Oct 21, 2020
@anitaa1990 anitaa1990 added this to To do in Add/Edit Products release 5 via automation Nov 10, 2020
@anitaa1990 anitaa1990 removed this from Bug/Crashes/Small enhancements in Add/Edit Products release 4 Nov 10, 2020
@anitaa1990 anitaa1990 moved this from To do to Bugs/Crashes/Small enhancements in Add/Edit Products release 5 Nov 10, 2020
@shiki shiki moved this from Needs Triage to Nice To Have in Add/Edit Products release 5 Nov 25, 2020
@shiki shiki added this to To do in Product Variations via automation Dec 22, 2020
@shiki shiki added this to Needs Triage in Continuous Improvements via automation Dec 22, 2020
@AliSoftware
Copy link
Contributor Author

Fixed by #3425

Continuous Improvements automation moved this from Needs Triage to Done Jan 14, 2021
Product Variations automation moved this from Nice to Have to Done (Sprint 2) Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: product list Related to the product list. type: bug A confirmed bug.
Projects
No open projects
Development

No branches or pull requests

1 participant