Toolbar issues with Menu screen

[nbradbury]

When I visit the Menu screen, the collapsible toolbar disappears entirely. If I go from there to the Reviews list, the toolbar briefly says "Menu" before being replaced by "Reviews." If I go from the Menu screen to the Inbox screen, the toolbar says "Menu."

[hafizrahman]

Thank you for the report, Nick! For this part:

When I visit the Menu screen, the collapsible toolbar disappears entirely.

The Figma design does exclude the toolbar:

[hichamboushaba]

If I go from the Menu screen to the Inbox screen, the toolbar says "Menu."

@JorgeMucientes it seems the InboxFragment doesn't override getFragmentTitle()

[hichamboushaba]

If I go from there to the Reviews list, the toolbar briefly says "Menu" before being replaced by "Reviews."

@nbradbury hopefully this PR #6255 will improve this, as the logic for the toolbar will be moved to onViewCreated instead of onDestinationChanged, onDestinationChanged is triggered before the actual navigation event, which causes having the wrong title for a short duration.

[JorgeMucientes]

Thanks for highlighting this @nbradbury

@JorgeMucientes it seems the InboxFragment doesn't override getFragmentTitle()

Yeah! That is fixed in this PR so the title shold display "Inbox" once it is merged. Thanks for the ping @hichamboushaba

Although there is the additional issue of seeing the toolbar flickering with the "Menu" title for some milliseconds when navigating from Menu fragment. Removing the override from MoreMenuFragment should fix the problem:

    override fun getFragmentTitle() = getString(R.string.more_menu)

[hichamboushaba]

Removing the override from MoreMenuFragment should fix the problem:

Yes, nice catch, I'll remove it in the PR #6255