Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image upload error fix #11383

Merged
merged 7 commits into from
Apr 26, 2024
Merged

Image upload error fix #11383

merged 7 commits into from
Apr 26, 2024

Conversation

0nko
Copy link
Contributor

@0nko 0nko commented Apr 25, 2024

Fixes #10329. The PR adds a notice when a site is in Private mode that the images are not accessible. Users were reporting that they can't upload images but it's not due to a bug in the app.

Light Dark
image image

To test:

  1. Log in to a site that is Public
  2. Go to Products -> Tap on some product
  3. Verify the images are available (either existing images or button to add one)
  4. In wp-admin set the site to Private mode in the Settings
  5. In the app, switch to a different site and switch back (or re-login)
  6. Go to Products -> Tap on some product
  7. Verify a notice is displayed instead of an image gallery
  8. Tap on the notice
  9. Verify a privacy settings website is opened
  10. Go back
  11. In wp-admin set the site to Coming soon mode in the Settings
  12. In the app, switch to a different site and switch back (or re-login)
  13. Go to Products -> Tap on some product
  14. Verify the images are available (either existing images or button to add one)

@dangermattic
Copy link
Collaborator

dangermattic commented Apr 25, 2024

1 Warning
⚠️ This PR is assigned to the milestone 18.4. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@0nko 0nko added the feature: product details Related to adding or editing products, includes product settings. label Apr 25, 2024
@0nko 0nko added this to the 18.4 milestone Apr 25, 2024
@0nko 0nko requested a review from atorresveiga April 25, 2024 20:00
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Apr 25, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit2c62580
Direct Downloadwoocommerce-prototype-build-pr11383-2c62580.apk

@atorresveiga atorresveiga self-assigned this Apr 25, 2024
Copy link
Contributor

@atorresveiga atorresveiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding work @0nko!!! Thanks for taking care of this. The code is working as expected and the UI is looking great.

np: I noticed that unit tests are failing, so we will need to update that file. Do you think it is worth adding a unit test covering the private site case to help document this case for future maintainers?

Pre-aproving this but we need to fix unit tests before merging the code

LGTM! :shipit:

@0nko
Copy link
Contributor Author

0nko commented Apr 26, 2024

Thanks @atorresveiga! I added the tests.

@0nko 0nko enabled auto-merge April 26, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: product details Related to adding or editing products, includes product settings.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Load Image
4 participants