-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image upload error fix #11383
Image upload error fix #11383
Conversation
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outstanding work @0nko!!! Thanks for taking care of this. The code is working as expected and the UI is looking great.
np: I noticed that unit tests are failing, so we will need to update that file. Do you think it is worth adding a unit test covering the private site case to help document this case for future maintainers?
Pre-aproving this but we need to fix unit tests before merging the code
LGTM!
Thanks @atorresveiga! I added the tests. |
Fixes #10329. The PR adds a notice when a site is in Private mode that the images are not accessible. Users were reporting that they can't upload images but it's not due to a bug in the app.
To test:
Public
wp-admin
set the site toPrivate
mode in the Settingswp-admin
set the site toComing soon
mode in the Settings