Send redirectUrl to listener and strip protocol before saving #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the url the user logs in with is redirected, we want to know the redirect url and use that for login. We save this url (or the original url) to app prefs with the protocol stripped since it's not needed for the rest of the login process and can cause issues when looking up the site by the url.
Generated by 🚫 dangerJS |
Generated by 🚫 dangerJS |
designsimply
added
feature: login
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1218 by using the redirect url when available instead of the entered url for matching the site to the authenticated user.
If the url the user logs in with is redirected, we want to know the redirect url and use that for the rest of the login process. We save this redirect url (or the original url) to
AppPrefswith the protocol stripped since it's not needed for the rest of the login process and can cause issues when looking up the site by the url to find a match for the authenticated user.Some special things to note:
The login process does not care which protocol the user enters (or if any at all). So entering
www.droidtester2018.com,droidtester2018.com,http://www.droidtester2018.comorhttps://droidtester2018.comwill all be handled identically. Here are examples:Examples
prepending with
www:prepending with
http://www:prepending with
https://Update release notes:
RELEASE-NOTES.txt.