-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark Mode v2: Site address help #2330
Conversation
The most recent designs call for the image to be above the text. Since the login library is shared, the closest I could get was to override the dialog content layout - but cannot include the title arrangement changes since that's set on the dialog in the login library.
You can test the changes on this Pull Request by downloading the APK here. |
Actually, let me take another look at this. Since it's just a title, moving it all into the view may not be a big deal... |
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR fixes #2325 by overriding the site address help dialog to better match designs. The most recent designs call for the image to be on top, then the title, then the body. Since the login library is shared, the closest I could get was to override the dialog content layout which places the image above the body - but cannot move the title since that's set in the login library when setting the alert dialog title.
@Garance91540
This is the closest I could get by overriding the login library layout. The dialog text is set programmatically in the login library and that's where android places the title - so overriding the layout only changes the body and image arrangement. Ideally we'd not be overriding layout files just because it then makes it difficult to track where to make changes, but if you think the changes are worth it, we can push it. Here are the comparisons:Never mind! I figured out a clean way to do this :) I just check if the login mode is "Woo" and only add the title if it's not. This way we could add the title to the layout as well. Updated the screenshots. I also updated the dialog theme to fix the padding on the button bars so they are 24dp.
Update release notes:
RELEASE-NOTES.txt
if necessary.