Unified Login: Site Address Flow

[AmandaRiu]

This PR is part of an epic to implement the unified login flow. This particular flow implements the site address login flow and includes the following scenarios:

• Clicking "Enter store address" opens the site address screen
• Login with email and using magic link to finish the login process
• Login with email and password to finish the login process
• Login with store credentials - match to WPcom account and use magic link to verify email and complete the login process
• Login with store credentials - login wtih WPcom email and password to complete the login process

Not included:

• Since the login with site address doesn't use the store selector, that screen has not been updated to the new styles yet.

Screenshots

Prologue	site address screen	email screen

magic link request	magic link sent	password

store creds	verify with magic link	magic link sent

To Test

• Verify entering site address and email, then logging in with magic link
• Verify entering site address, then entering store credentials and using magic link
• Verify entering site address, then entering store credentials and using password

Update release notes:

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-woocommerce]

	Fails
🚫	Danger failed to run /app/danger-0.3jko55ajr0z.ts.
🚫	Danger failed to run /app/danger-0.gxu6r3vqiga.ts.

	Warnings
⚠️	PR is not assigned to a milestone.

Messages

📖

This PR contains changes in the subtree libs/login/. It is your responsibility to ensure these changes are merged back into wordpress-mobile/WordPress-Login-Flow-Android. Follow these handy steps! WARNING: Make sure your git version is 2.19.x or lower - there is currently a bug in later versions that will corrupt the subtree history! cd woocommerce-android git checkout issue/2656-wire-main-screens git subtree push --prefix=libs/login/ https://github.com/wordpress-mobile/WordPress-Login-Flow-Android.git merge/woocommerce-android/2773 Browse to https://github.com/wordpress-mobile/WordPress-Login-Flow-Android/pull/new/merge/woocommerce-android/2773 and open a new PR.

Error TypeError

Cannot read property 'added' of null
TypeError: Cannot read property 'added' of null
    at Object.exports.default (/app/danger-0.3jko55ajr0z.ts:16:44)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Dangerfile

11|         warn("The PlayStoreStrings.po file must be updated any time changes are made to release notes");
12|     }
13| 
14|     // If changes were made to the strings, make sure they follow our guidelines
15|     const modifiedStrings = modifiedFiles.filter((path: string) => path.endsWith('values/strings.xml'))
----------------------------------------------^
16| 
17|     for (let file of modifiedStrings) {        
18|         const stringDiffs = await danger.git.diffForFile(file)
19| 

Error TypeError

Cannot read property 'diff' of null
TypeError: Cannot read property 'diff' of null
    at checkCommitDiffs (/app/danger-0.gxu6r3vqiga.ts:43:49)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Dangerfile

38|         if (git === undefined) {
39|             console.log("About to crash due to an error")
40|             console.log("File:", thisFile)
41|             console.log("Danger Object: ", danger)
42| 
---------------------------------------------------^
43|             if (danger !== undefined) {
44|                 console.log("Danger is no longer defined")
45|             }
46|             else {

Generated by 🚫 dangerJS

[0nko]

After typing my site address and clicking on Continue, when I tap on the email EditText, I'm getting a crash:

kotlin.NotImplementedError: An operation is not implemented: Not yet implemented
        at com.woocommerce.android.ui.login.LoginAnalyticsTracker.trackSelectEmailField(LoginAnalyticsTracker.kt:263)
        at org.wordpress.android.login.LoginEmailFragment$2.onFocusChange(LoginEmailFragment.java:217)
        at android.view.View.onFocusChanged(View.java:8116)

Entering store credentials with password: When submitting my 2FA, I got this crash:

    kotlin.NotImplementedError: An operation is not implemented: Not yet implemented
        at com.woocommerce.android.ui.login.LoginAnalyticsTracker.trackSubmit2faCodeClicked(LoginAnalyticsTracker.kt:239)
        at org.wordpress.android.login.Login2FaFragment.next(Login2FaFragment.java:291)
        at org.wordpress.android.login.Login2FaFragment.onEditorCommit(Login2FaFragment.java:365)
        at org.wordpress.android.login.widgets.WPLoginInputRow$1.onEditorAction(WPLoginInputRow.java:152)

[AmandaRiu]

@0nko Thanks for the review. The tracks stuff bit me! LOL! I've been removing the TODO() stuff as I hit them so I would know which ones we are definitely using, but apparently missed a part of the flow. Should be fixed now.

[0nko]

Works as expected 👍