Unified login: Hide TOS buttons if not in signup mode during login

[AmandaRiu]

This PR closes #2837 by hiding the Terms of Service buttons when not in a "Signup" flow. WooCommerce app does not currently support signup during login.

Before	After

To Test

1. Click Continue with WordPress.com
2. Notice the TOS text is not visible in the email form view.

Update release notes:

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-woocommerce]

	Fails
🚫	Danger failed to run /app/danger-0.hcbz7xzj4gp.ts.

Messages

📖

This PR contains changes in the subtree libs/login/. It is your responsibility to ensure these changes are merged back into wordpress-mobile/WordPress-Login-Flow-Android. Follow these handy steps! WARNING: Make sure your git version is 2.19.x or lower - there is currently a bug in later versions that will corrupt the subtree history! cd woocommerce-android git checkout issue/2837-hide-tos git subtree push --prefix=libs/login/ https://github.com/wordpress-mobile/WordPress-Login-Flow-Android.git merge/woocommerce-android/2845 Browse to https://github.com/wordpress-mobile/WordPress-Login-Flow-Android/pull/new/merge/woocommerce-android/2845 and open a new PR.

Error TypeError

Cannot read property 'diff' of null
TypeError: Cannot read property 'diff' of null
    at checkCommitDiffs (/app/danger-0.hcbz7xzj4gp.ts:43:49)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Dangerfile

38|         if (git === undefined) {
39|             console.log("About to crash due to an error")
40|             console.log("File:", thisFile)
41|             console.log("Danger Object: ", danger)
42| 
---------------------------------------------------^
43|             if (danger !== undefined) {
44|                 console.log("Danger is no longer defined")
45|             }
46|             else {

Generated by 🚫 dangerJS

[peril-woocommerce]

You can test the changes on this Pull Request by downloading the APK here.

[nbradbury]

I don't think this bug was introduced in this PR, but when the TOS button is clicked it doesn't do anything.

[AmandaRiu]

Yeah that's because we don't use it (which is why I'm hiding it). It's used by WPAndroid though which is why it exists.

[nbradbury]