Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Login: No WPcom found error screen #2943

Merged
merged 9 commits into from
Oct 2, 2020
Merged

Conversation

AmandaRiu
Copy link
Contributor

@AmandaRiu AmandaRiu commented Sep 30, 2020

Closes #2815. During the WordPress.com login flow, if the user enters an email address that is not associated with a WPcom account, then this new error screen is shown:

Before After (light) After (dark)
Screenshot_1601505407_framed Screenshot_1601580317_framed Screenshot_1601580341_framed

Tracks events

The following Flow, Step and Click tracks events were added:

  • Step: no_wpcom_account_found - tracked as soon as this screen is shown
  • Click: help_finding_connected_email - when clicking on the link to get help finding connected email
  • Click: try_another_account - when clicking try another account
  • Click: login_with_site_address - when clicking the option to login with site address

Track event samples:

Tracked: unified_login_step, Properties: {"source":"default","flow":"google_login","step":"no_wpcom_account_found"}
Tracked: unified_login_interaction, Properties: {"source":"default","flow":"google_login","step":"no_wpcom_account_found","click":"help_finding_connected_email"}
Tracked: unified_login_interaction, Properties: {"source":"default","flow":"login_site_address","step":"no_wpcom_account_found","click":"try_another_account"}
Tracked: unified_login_interaction, Properties: {"source":"default","flow":"google_login","step":"no_wpcom_account_found","click":"login_with_site_address"}

To Test

  1. Launch the app to login
  2. Click on Continue with WordPress.com
  3. Enter an email address not associated with a WordPress.com account - verify new error screen is displayed
  4. Click each button on screen to verify action and track event.

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-woocommerce
Copy link

peril-woocommerce bot commented Sep 30, 2020

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.
Messages
📖

This PR contains changes in the subtree libs/login/. It is your responsibility to ensure these changes are merged back into wordpress-mobile/WordPress-Login-Flow-Android. Follow these handy steps!
WARNING: Make sure your git version is 2.19.x or lower - there is currently a bug in later versions that will corrupt the subtree history!

  1. cd woocommerce-android
  2. git checkout issue/2815-ul-wrong-wp
  3. git subtree push --prefix=libs/login/ https://github.com/wordpress-mobile/WordPress-Login-Flow-Android.git merge/woocommerce-android/2943
  4. Browse to https://github.com/wordpress-mobile/WordPress-Login-Flow-Android/pull/new/merge/woocommerce-android/2943 and open a new PR.

Generated by 🚫 dangerJS

@peril-woocommerce
Copy link

peril-woocommerce bot commented Sep 30, 2020

You can test the changes on this Pull Request by downloading the APK here.

@AmandaRiu
Copy link
Contributor Author

@Garance91540 This requires a design review:

  • Since this error screen happens after entering an email address, I changed the error message to “It looks like isn’t associated with a WordPress.com account”. Please let me know if this is okay.
  • The image asset had some errors when I tried to import it into Android Studio so the "WordPress" logo is missing. The error was The stroke-dasharray attribute is not supported. Maybe you can tweak the asset? Please let me know how to proceed.
  • I also need a dark version of this image asset.

Many thanks!!

@AmandaRiu AmandaRiu added needs: design Requires design input/work from a designer. Login labels Sep 30, 2020
@AmandaRiu AmandaRiu added this to the 5.2 milestone Sep 30, 2020
@Garance91540
Copy link

Hi Amanda! Everythink looks good, except I notice some fonts seem to not be right (we can tackle this in a separate PR):

The font for these should be: Roboto Medium 14

Thanks!

@AmandaRiu
Copy link
Contributor Author

Updated with recommendations from @Garance91540 and updated screenshots. This one is ready for review 👍

@AmandaRiu AmandaRiu marked this pull request as ready for review October 1, 2020 19:28
@AmandaRiu AmandaRiu requested a review from a team October 1, 2020 19:28
@AmandaRiu AmandaRiu removed the needs: design Requires design input/work from a designer. label Oct 1, 2020
@nbradbury nbradbury self-assigned this Oct 1, 2020
@nbradbury nbradbury self-requested a review October 1, 2020 19:48
@nbradbury
Copy link
Contributor

@AmandaRiu If I enter a non-WP email address and choose "Log in with another account" from the No WPcom found error screen, after I return to the prologue screen tapping "Continue with WordPress.com" does nothing.

Also, unrelated but wanted to mention it: there's no ripple on the "Continue with WordPress.com" button.

@AmandaRiu
Copy link
Contributor Author

@nbradbury Great catches! Fixed and ready for another round!

Copy link
Contributor

@nbradbury nbradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! :shipit:

@nbradbury nbradbury merged commit 732096a into develop Oct 2, 2020
@nbradbury nbradbury deleted the issue/2815-ul-wrong-wp branch October 2, 2020 11:24
@Garance91540
Copy link

Hi @AmandaRiu , you mentioned you updated the screenshots but I'm not sure? The buttons fonts needs to be Roboto Medium 14 https://d.pr/i/aRDLGM

@designsimply designsimply added feature: login Related to any part of the log in or sign in flow, or authentication. and removed Login labels May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: login Related to any part of the log in or sign in flow, or authentication.
Projects
No open projects
Unified Login
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

Unified Login: No matching WPcom account
4 participants