-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified Login: No WPcom found error screen #2943
Conversation
This hook will allow us to show the new "No WordPress.com account found" error screen.
Generated by 🚫 dangerJS |
You can test the changes on this Pull Request by downloading the APK here. |
@Garance91540 This requires a design review:
Many thanks!! |
Hi Amanda! Everythink looks good, except I notice some fonts seem to not be right (we can tackle this in a separate PR):
The font for these should be: Roboto Medium 14
Thanks! |
Updated with recommendations from @Garance91540 and updated screenshots. This one is ready for review 👍 |
@AmandaRiu If I enter a non-WP email address and choose "Log in with another account" from the No WPcom found error screen, after I return to the prologue screen tapping "Continue with WordPress.com" does nothing. Also, unrelated but wanted to mention it: there's no ripple on the "Continue with WordPress.com" button. |
@nbradbury Great catches! Fixed and ready for another round! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Hi @AmandaRiu , you mentioned you updated the screenshots but I'm not sure? The buttons fonts needs to be Roboto Medium 14 https://d.pr/i/aRDLGM |
Closes #2815. During the WordPress.com login flow, if the user enters an email address that is not associated with a WPcom account, then this new error screen is shown:
Tracks events
The following
Flow
,Step
andClick
tracks events were added:no_wpcom_account_found
- tracked as soon as this screen is shownhelp_finding_connected_email
- when clicking on the link to get help finding connected emailtry_another_account
- when clicking try another accountlogin_with_site_address
- when clicking the option to login with site addressTrack event samples:
To Test
Update release notes:
RELEASE-NOTES.txt
if necessary.