issue/3154-login-site-address-crash-fix

[anitaa1990]

Fixes #3154 by adding a null check when user enters a site address during login. I haven't been able to reproduce the issue but it looks like we set the mSiteAddressInput=null when the fragment is destroyed. So if the onTextChanged is called before the mSiteAddressInput could be initialised again, this crash could potentially happen.

Given that we needn't update the mSiteAddressInput field after the fragment is destroyed, it seemed enough to do just a null check here to ensure that this crash doesn't happen again.

Update release notes:

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-woocommerce]

Messages

📖

This PR contains changes in the subtree libs/login/. It is your responsibility to ensure these changes are merged back into wordpress-mobile/WordPress-Login-Flow-Android. Follow these handy steps! WARNING: Make sure your git version is 2.19.x or lower - there is currently a bug in later versions that will corrupt the subtree history! cd woocommerce-android git checkout issue/3154-login-site-address-crash-fix git subtree push --prefix=libs/login/ https://github.com/wordpress-mobile/WordPress-Login-Flow-Android.git merge/woocommerce-android/3203 Browse to https://github.com/wordpress-mobile/WordPress-Login-Flow-Android/pull/new/merge/woocommerce-android/3203 and open a new PR.

Generated by 🚫 dangerJS

[peril-woocommerce]

You can test the changes on this Pull Request by downloading the APK here.

[AmandaRiu]

Looks good @anitaa1990. Thank you for taking care of this.