Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UL: Modified password and passwordless flow #3268

Merged
merged 7 commits into from
Dec 8, 2020
Merged

UL: Modified password and passwordless flow #3268

merged 7 commits into from
Dec 8, 2020

Conversation

AmandaRiu
Copy link
Contributor

@AmandaRiu AmandaRiu commented Dec 3, 2020 •
edited

Fixes #3120 by implementing the new password and passwordless designs for unified login.

  • The extra step for magic link has been removed
  • Login via a passwordless WordPress.com account now supported (account created via SIWA)
  • New password layout screen now used.
Password Login Magic Link Login
password magic-link

To Test

The following tests all use the "Log In with WordPress.com" option.

Login with Password

  1. Click Log in with WordPress.com
  2. Enter WordPress.com account email, click Continue
  3. Enter password, click Continue, login successful

Login with Magic Link

  1. Click Log in with WordPress.com
  2. Enter WordPress.com account email, click Continue
  3. Click Get a login link by email option. The magic link request screen will briefly be displayed before auto-routing to the Magic Link sent screen.
  4. Finish logging in via magic link

Passwordless login

  1. Click Log in with WordPress.com
  2. Enter WordPress.com account email (Use an account that was created via SIWA)
  3. Click Continue. The magic link request screen will briefly be displayed before auto-routing to the Magic Link sent screen.
  4. Finish logging in via magic link

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@AmandaRiu AmandaRiu added [Status] Not Ready for Review needs: design Requires design input/work from a designer. labels Dec 3, 2020
@AmandaRiu AmandaRiu added this to the 5.7 milestone Dec 3, 2020
@AmandaRiu AmandaRiu marked this pull request as draft December 3, 2020 02:37
@peril-woocommerce
Copy link

peril-woocommerce bot commented Dec 3, 2020 •
edited

You can test the changes on this Pull Request by downloading the APK here.

Garance91540
Garance91540 previously approved these changes Dec 3, 2020
View reviewed changes
Copy link

@Garance91540 Garance91540 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏

@AmandaRiu AmandaRiu removed needs: design Requires design input/work from a designer. [Status] Not Ready for Review labels Dec 7, 2020
@AmandaRiu AmandaRiu requested a review from a team December 7, 2020 00:07
@AmandaRiu
Copy link
Contributor Author

This one is ready for review 👍

@AmandaRiu AmandaRiu marked this pull request as ready for review December 7, 2020 15:31
@Garance91540
Copy link

@AmandaRiu one quick note: on the screencast you shared, when you select "get a login link by email", I'm seeing the first magic link screen flashing and then the second magic link screen. Is it possible to remove completely the first "flashing" screen?

@AmandaRiu
Copy link
Contributor Author

@AmandaRiu one quick note: on the screencast you shared, when you select "get a login link by email", I'm seeing the first magic link screen flashing and then the second magic link screen. Is it possible to remove completely the first "flashing" screen?

@Garance91540 That screen you see flashing is just the "requesting magic link" screen which you'll want to show if someone has a slow connection (otherwise it will feel like the app has frozen). We could and should change the designs around this but I think in that case it'd make sense to coordinate with WPAndroid as well since these screens are part of the shared flow the two apps use. If the designs could join the "Requesting magic link" and "magic link sent" into a single view where maybe there's a progress animation then the flow wouldn't feel so jarring.

@nbradbury nbradbury self-requested a review December 8, 2020 15:55
@nbradbury nbradbury self-assigned this Dec 8, 2020
nbradbury
nbradbury previously approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@nbradbury nbradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :shipit:

@nbradbury
Copy link
Contributor

@AmandaRiu I was just about to merge this but saw there are now conflicts in the release notes.

@AmandaRiu
Copy link
Contributor Author

@nbradbury resolved the conflict. Ready for merge!

nbradbury
nbradbury approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@nbradbury nbradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nbradbury nbradbury merged commit 12dc649 into develop Dec 8, 2020
@nbradbury nbradbury deleted the issue/3120-passwordless-login branch December 8, 2020 21:02
This was referenced Dec 17, 2020
Closed
Open
@designsimply designsimply added feature: login Related to any part of the log in or sign in flow, or authentication. and removed Login labels May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbradbury nbradbury nbradbury approved these changes

@Garance91540 Garance91540 Garance91540 left review comments

Assignees

@nbradbury nbradbury

Labels
feature: login Related to any part of the log in or sign in flow, or authentication.
Projects
No open projects
Unified Login
  
Awaiting triage
Milestone
5.7
Development

Successfully merging this pull request may close these issues.

[Unified Login - Continue with WP.com] - Pwd step
4 participants
@AmandaRiu @Garance91540 @nbradbury @designsimply