Beta Fix: Fix broken "reset password" link on site creds login screen #3363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was stripping the protocol from the URL for the label but then using that same URL for routing to the reset password view. Logic has been updated to strip the protocol for display only when needed.
This was somehow removed when the app translations were updated.
Generated by 🚫 dangerJS |
|
You can test the changes on this Pull Request by downloading the APK here. |
nbradbury
reviewed
Dec 19, 2020
| @@ -201,8 +201,9 @@ protected void setupLabel(@NonNull TextView label) { | |||
| break; | |||
| case WOO_LOGIN_MODE: | |||
| if (mOptionalSiteCredsLayout) { | |||
| String siteAddressClean = mLoginSiteUrl.replaceFirst("^(http[s]?://)", ""); | |||
There was a problem hiding this comment.
NP: Changes look good and I'll merge this, but wanted to mention that it would be good to move this logic to StringUtils since there's more than one place we remove the protocol for display.
This was referenced Dec 28, 2020
AliSoftware
added a commit
that referenced
this pull request
Jan 11, 2021
Not sure if this change is correct. Matches what we see in GlotPress indeed, but don't think that's what we wanted? See #3363
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3349 The issue was stripping the protocol from the URL for the label but then using that same URL for routing to the reset password view. Logic has been updated to strip the protocol for display only when needed for display.
To Test
cc: @AliSoftware for a beta release
Update release notes:
RELEASE-NOTES.txtif necessary.