Fix LoginEmailFragment NPE crash in onActivityResult() #413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #408
The Issue
The crash is around the email address hint functionality on the email field for login. A NPE is thrown in the
onActiivtyResult()
method of theLoginEmailFragment
. ThemEmailInput
variable is null and the code is attempting to call a method on this variable inonActivityResult()
:mEmailInput
gets initialized in thesetupContent()
method which is called duringonCreateView()
in the base Fragment class. So knowing this I'm assuming that somehowLoginEmailFragment
'sonActivityResult()
is being called beforeonCreateView()
. I've tried to replicate this crash by enabling "Don't keep activities" and trying to somehow hit that sweet spot where I activate the TextInput and then put the app in the background before the hint results are returned. No luck.The Fix
Verify
mEmailInput
is not null before attempting to access it. There is no side effect of this fix since whensetupContent()
is finally called andmEmailInput
is initialized, the email hint code will be called again.