Update login lib - Run XML-RPC discovery during SiteAddress login flow #4799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malinajirka
added
the
feature: login
malinajirka
changed the title
malinajirka
changed the title
|
You can test the changes on this Pull Request by downloading the APK here. |
malinajirka
added
status: do not merge
malinajirka
added
status: do not merge
|
I'll be afk next week - please feel free to fix issues found during the review but also feel free to leave it up to me when I get back. Thanks 🙇 |
shiki
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
Approved in: wordpress-mobile/WordPress-Login-Flow-Android#67 (review)
I'll wait for @designsimply to chime in there.
# Conflicts: # build.gradle
|
Apologies for the delayed reply!! I chimed in at wordpress-mobile/WordPress-Login-Flow-Android#67 (comment) with really only one odd case that might be worth looking into. This looks so great btw! Thank you for working on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3767
"Do not merge" label - remove the label after updating lib-reference with reference to develop of the login lib
Description
Updates the login library - this PR contains details about the changes in the library -> the app now shows various xml-rpc errors.
Testing instructions
Refer to wordpress-mobile/WordPress-Login-Flow-Android#67
Images/gif
RELEASE-NOTES.txtif necessary.