Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tos link color #4972

Merged
merged 5 commits into from
Oct 13, 2021
Merged

Change tos link color #4972

merged 5 commits into from
Oct 13, 2021

Conversation

rossanafmenezes
Copy link
Contributor

Fixes #4185

Changes

Changes the TOS link color in the login screen from WordPress-Login-Flow-Android (PR #71)

Screenshots

Before After

Testing Instructions

  • Open the app while logged out

  • tap on Continue with WordPress.com

  • See the TOS links below the email field and Google Login

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Change tos link color  on login screen to colorSecondary.
@rossanafmenezes rossanafmenezes added the type: enhancement A request for an enhancement. label Oct 8, 2021
@rossanafmenezes rossanafmenezes added this to the 7.8 milestone Oct 8, 2021
@rossanafmenezes rossanafmenezes requested a review from a team October 8, 2021 11:47
@rossanafmenezes rossanafmenezes added this to In Review in Continuous Improvements via automation Oct 8, 2021
@rossanafmenezes rossanafmenezes requested review from anitaa1990 and removed request for a team October 8, 2021 11:47
@peril-woocommerce
Copy link

peril-woocommerce bot commented Oct 8, 2021

You can test the changes on this Pull Request by downloading the APK here.

@anitaa1990 anitaa1990 self-assigned this Oct 12, 2021
Copy link
Contributor

@anitaa1990 anitaa1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @rossanafmenezes! I already reviewed and merged the Login lib PR. Would you update the merged commit hash into this PR and we can merge 👍

@anitaa1990 anitaa1990 merged commit 7cd17e9 into develop Oct 13, 2021
@anitaa1990 anitaa1990 deleted the issue/4185-tos-link-color branch October 13, 2021 04:48
Continuous Improvements automation moved this from In Review to Done Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A request for an enhancement.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Log in: the "Terms of Service" link color should be Pink 50
2 participants