Feature/6881 what is wordpress #6891

JorgeMucientes · 2022-07-07T13:25:38Z

Closes: #6881

Description

Part of Experiment 2: Add more information about the login process in pe5sF9-6C-p2

Adds a new link to log in with WordPress email screen that redirects to web site explaining why WordPress.com is needed to log in inside WooCommerce

Additionally this PR decouples LoginSiteAddressFragment and LoginEmailFragment from WordPress login library. This enables us to add changes to the UI in these 2 screens without updating the library.

Testing instructions

Open Login prologue screen and click "Continue with WordPress.com"
Click on link "What is WordPress.com?" and see the navigates to link correctly
Check that event unified_login_interaction, Properties: {"source":"default","flow":"wordpress_com","step":"enter_email_address","click":"what_is_wordpress_com","is_debug":true} with property value "click":"what_is_wordpress_com" is tracked in console log.

Images/gif

LinkWhatIsWordPress.mp4

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

…ss auth lib

- The goal is to be able to change the UI freely from WooCommerce - Converted into Kotlin

…ouple-login-with-email-from-lib # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/login/LoginActivity.kt

peril-woocommerce · 2022-07-07T13:25:44Z

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

JorgeMucientes · 2022-07-07T13:30:28Z

WooCommerce/src/main/kotlin/com/woocommerce/android/di/LoginFragmentsModule.kt

@@ -0,0 +1,18 @@
+package com.woocommerce.android.di


WordPress login lib uses Dagger to inject deps on fragments. Since WooLoginEmailFragment and WooLoginSiteAddressFragment inherit from fragments that belong to the Login lib that are injecting their deps using:

@Override public void onAttach(Context context) { AndroidSupportInjection.inject(this); super.onAttach(context); }

So we need this module for injected deps in these fragments to work. The Hilt approach of annotating the fragment with @AndroidEntryPoint won't work if the fragment also invokes:
AndroidSupportInjection.inject(this);

wpmobilebot · 2022-07-07T13:38:43Z

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

codecov-commenter · 2022-07-07T13:39:55Z

Codecov Report

Merging #6891 (67273db) into trunk (ee8a73b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 67273db differs from pull request most recent head 259680a. Consider uploading reports for the commit 259680a to get more accurate results

@@             Coverage Diff              @@
##              trunk    #6891      +/-   ##
============================================
- Coverage     44.57%   44.56%   -0.02%     
- Complexity     3007     3008       +1     
============================================
  Files           539      539              
  Lines         29828    29819       -9     
  Branches       3945     3942       -3     
============================================
- Hits          13296    13289       -7     
+ Misses        15291    15289       -2     
  Partials       1241     1241

Impacted Files	Coverage Δ
...oocommerce/android/ui/login/UnifiedLoginTracker.kt	`42.53% <100.00%> (+0.43%)`	⬆️
...ndroid/ui/cardreader/hub/CardReaderHubViewModel.kt	`98.66% <0.00%> (+0.01%)`	⬆️
...rdreader/onboarding/CardReaderOnboardingChecker.kt	`93.61% <0.00%> (+0.02%)`	⬆️
...reader/onboarding/CardReaderOnboardingViewModel.kt	`96.25% <0.00%> (+0.40%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ced3b09...259680a. Read the comment docs.

JorgeMucientes · 2022-07-08T12:43:42Z

WooCommerce/src/main/res/layout/fragment_login_email_screen.xml

+        <com.google.android.material.button.MaterialButton
+            android:id="@+id/login_what_is_wordpress"
+            style="@style/Widget.LoginFlow.Button.Tertiary"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:layout_marginStart="@dimen/margin_extra_large"
+            android:layout_marginEnd="@dimen/margin_extra_large"
+            android:text="@string/what_is_wordpress_link"
+            app:layout_constraintEnd_toEndOf="parent"
+            app:layout_constraintStart_toStartOf="parent"
+            app:layout_constraintTop_toBottomOf="@+id/login_continue_button" />


Copy pasted this layout file from the WordPress login library and then added this change.

peril-woocommerce · 2022-07-08T12:55:39Z

	Warnings
⚠️	This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

hichamboushaba

Code looks good, and feature works good

hichamboushaba · 2022-07-08T15:22:52Z

@JorgeMucientes this can be merged after fixing the merge conflict

JorgeMucientes added 17 commits July 6, 2022 08:38

Add LoginEmailFragment to woo app project to decouple it from WordPre…

2a35e0a

…ss auth lib

Add new link what is Wordpress.com

7ce4e22

Extract LoginSiteAddressFragment out of login library

3b9efb7

- The goal is to be able to change the UI freely from WooCommerce - Converted into Kotlin

Fix dependency injection issues LoginSiteAddressFragment

c3bece3

Add new layout for LoginSiteAddressFragment

282b656

Override LoginSiteAddressFragment UI using inheritance

6cc8e44

Merge branch 'poc/decouple-store-address-login-from-lib' into poc/dec…

94e1730

…ouple-login-with-email-from-lib # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/login/LoginActivity.kt

Override WooLoginEmailFragment UI using inheritance

c1e4d0b

Rename package were fragments overriding login lib are placed

fab8ee5

Revert test added view

9572a32

Handle clicks over new link "What is WordPress.com"

99348eb

Fix typo

1d5fbfc

Merge branch 'trunk' into poc/decouple-login-with-email-from-lib

90f29fb

Adjust UI for What is WordPress link

fc4b52c

Add listener for What is WordPress.com link to LoginActivity

1477f3a

Add tracking for new link

a49140b

Fix checkstyle indentation issue

11bce1f

JorgeMucientes added feature: login Related to any part of the log in or sign in flow, or authentication. type: enhancement A request for an enhancement. labels Jul 7, 2022

JorgeMucientes added this to the 9.6 milestone Jul 7, 2022

JorgeMucientes commented Jul 7, 2022

View reviewed changes

Simplify getContentLayout to make it an expression

9b2955c

JorgeMucientes requested a review from hichamboushaba July 7, 2022 13:39

JorgeMucientes requested a review from hafizrahman July 7, 2022 13:39

hichamboushaba self-assigned this Jul 8, 2022

JorgeMucientes commented Jul 8, 2022

View reviewed changes

Update release notes

67273db

hichamboushaba approved these changes Jul 8, 2022

View reviewed changes

Merge branch 'trunk' into feature/6881-what-is-wordpress

259680a

JorgeMucientes enabled auto-merge July 10, 2022 20:06

JorgeMucientes merged commit 07787d2 into trunk Jul 10, 2022

JorgeMucientes deleted the feature/6881-what-is-wordpress branch July 10, 2022 20:20

hichamboushaba mentioned this pull request Aug 1, 2022

Add an alternative "magic link sent" screen wordpress-mobile/WordPress-Login-Flow-Android#88

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/6881 what is wordpress #6891

Feature/6881 what is wordpress #6891

JorgeMucientes commented Jul 7, 2022 •

edited

peril-woocommerce bot commented Jul 7, 2022 •

edited

JorgeMucientes Jul 7, 2022 •

edited

wpmobilebot commented Jul 7, 2022 •

edited

codecov-commenter commented Jul 7, 2022 •

edited

JorgeMucientes Jul 8, 2022

peril-woocommerce bot commented Jul 8, 2022

hichamboushaba left a comment

hichamboushaba commented Jul 8, 2022

Feature/6881 what is wordpress #6891

Feature/6881 what is wordpress #6891

Conversation

JorgeMucientes commented Jul 7, 2022 • edited

Description

Testing instructions

Images/gif

peril-woocommerce bot commented Jul 7, 2022 • edited

JorgeMucientes Jul 7, 2022 • edited

Choose a reason for hiding this comment

wpmobilebot commented Jul 7, 2022 • edited

codecov-commenter commented Jul 7, 2022 • edited

Codecov Report

JorgeMucientes Jul 8, 2022

Choose a reason for hiding this comment

peril-woocommerce bot commented Jul 8, 2022

hichamboushaba left a comment

Choose a reason for hiding this comment

hichamboushaba commented Jul 8, 2022

JorgeMucientes commented Jul 7, 2022 •

edited

peril-woocommerce bot commented Jul 7, 2022 •

edited

JorgeMucientes Jul 7, 2022 •

edited

wpmobilebot commented Jul 7, 2022 •

edited

codecov-commenter commented Jul 7, 2022 •

edited