Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update login library version #7240

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Conversation

hafizrahman
Copy link
Contributor

@hafizrahman hafizrahman commented Aug 19, 2022

To fix site credentials login crash related to recent changes in FluxC. More info in wordpress-mobile/WordPress-Login-Flow-Android#92

I already tested the fix related to the crash when reviewing the PR above, so we don't need to test again here. But for completeness sake, this was the crash:

  1. Start app,
  2. Go to Enter store address flow,
  3. Enter a self-hosted Woo site with Jetpack connected,
  4. Go to site credentials screen (can be served right away if you get A/B tested there; if you get email login screen instead, use "Continue with store credentials" button at the bottom),
  5. Enter site username/password
  6. Crash

@hafizrahman hafizrahman added this to the 10.0 milestone Aug 19, 2022
@peril-woocommerce
Copy link

peril-woocommerce bot commented Aug 19, 2022

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@ParaskP7 ParaskP7 self-assigned this Aug 19, 2022
@wpmobilebot
Copy link
Collaborator

Found 1 violations:

The PR caused the following dependency changes:

expand

-\--- org.wordpress:login:0.17.0
+\--- org.wordpress:login:trunk-e11535105725e02dd1e8aa8065314ceb67079278

Please review and act accordingly

Copy link
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

I reviewed the change but didn't test it (per your description), thank you for the quick fix @hafizrahman ! 🥇

PS: The change is just one commit diff on the Login side library, that is, versus 0.17.0, so I think it is safe to merge it.

@wpmobilebot
Copy link
Collaborator

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants